GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Mark local variable as const by xtqqczze · Pull Request #13217 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

  • Fix RCS1118: Mark local variable as const
  • Inline various constants
  • Extract various constants

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • [NA] Experimental feature(s) needed
      • [NA] Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • [NA] Documentation needed
      • [NA] Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Rob Holt (rjmholt) Jul 20, 2020
@rjmholt
Rob Holt (rjmholt) requested review from Steve Lee (SteveL-MSFT), Dongbo Wang (daxian-dbw) and Ilya (iSazonov) and removed request for Ilya (iSazonov) July 20, 2020 19:04
iSazonov
Ilya (iSazonov) reviewed Jul 21, 2020
View reviewed changes
Comment thread ...stem.Management.Automation/FormatAndOutput/common/DisplayDatabase/typeDataXmlLoader_Table.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
xtqqczze
xtqqczze commented Jul 21, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/commands/CustomShellCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze force-pushed the RCS1118 branch from 9385208 to 30608bb Compare July 22, 2020 22:08
iSazonov
Ilya (iSazonov) reviewed Jul 23, 2020
View reviewed changes
Comment thread ...stem.Management.Automation/FormatAndOutput/common/DisplayDatabase/typeDataXmlLoader_Table.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 23, 2020
Unreachable code in typeDataXmlLoader_Table.cs #13246
Closed
Naming convention for local constants #13247
Closed
@xtqqczze
xtqqczze force-pushed the RCS1118 branch 2 times, most recently from 7c0dc96 to 3bc6352 Compare July 23, 2020 12:42
iSazonov
Ilya (iSazonov) approved these changes Jul 23, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/NativeCommandParameterBinder.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 23, 2020
rjmholt
Rob Holt (rjmholt) reviewed Jul 23, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePrompt.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Jul 25, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) It seems analyzers do not find code fixes inside an #if directive (unless the expression is true at compile time). This means code fixes inside #if UNIX etc have been missed from previous PRs. (Roslynator issue)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze marked this pull request as ready for review July 25, 2020 17:35
@xtqqczze
xtqqczze requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) as code owners July 25, 2020 17:35
rjmholt
Rob Holt (rjmholt) approved these changes Jul 26, 2020
View reviewed changes
@rjmholt

Rob Holt (rjmholt) commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator

I'll give some extra time for other reviewers. They're likely to be out next week, so we may have to wait a little whlie
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

It seems analyzers do not find code fixes inside an #if directive

xtqqczze It is expected - the analyzers work at compile. You could target an Unix while run analyzers. But it is not critical.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt

Rob Holt (rjmholt) commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 10 days
PoshChan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt Rob Holt (rjmholt) added the Review - Needed The PR is being reviewed label Jul 28, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 30, 2020
@xtqqczze
xtqqczze force-pushed the RCS1118 branch from 4c07ad1 to 97723ee Compare August 3, 2020 19:42
@xtqqczze

xtqqczze commented Aug 3, 2020

Copy link
Copy Markdown
Contributor Author

rebased to resolve #13316 conflict
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Oct 18, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Stale label Oct 18, 2020
@iSazonov
Ilya (iSazonov) marked this pull request as ready for review October 19, 2020 04:18
@iSazonov

Ilya (iSazonov) commented Oct 19, 2020

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt) Steve Lee (@SteveL-MSFT) I think we can merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Stale label Oct 19, 2020
@ghost ghost added the Stale label Nov 3, 2020
@ghost

Deleted user (ghost) commented Nov 3, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

This PR is ready for final review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Nov 3, 2020
iSazonov
Ilya (iSazonov) approved these changes Nov 3, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 12, 2020
@ghost

Deleted user (ghost) commented Nov 12, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Merge remote-tracking branch 'upstream/master' into RCS1118
d035cec
@xtqqczze
xtqqczze marked this pull request as draft November 13, 2020 01:04
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@iSazonov

Ilya (iSazonov) commented Nov 18, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Is it still Draft?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 18, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review November 18, 2020 08:41
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 18, 2020
@iSazonov

Ilya (iSazonov) commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@iSazonov

Ilya (iSazonov) commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Merge branch 'master' into RCS1118
af615ee
iSazonov
Ilya (iSazonov) approved these changes Nov 24, 2020
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit c7bdb24 into PowerShell:master Nov 24, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@xtqqczze
xtqqczze deleted the RCS1118 branch November 24, 2020 16:30
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Mark local variable as const (PowerShell#13217)
b29b091 
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @rjmholt @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.