GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Autofix SA1518: No extra blank lines at the end of the file by xtqqczze · Pull Request #13574 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 4, 2020 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Autofix SA1518: The code must not contain blank lines at the end of the file.

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1518.md

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • [NA] Experimental feature(s) needed
      • [NA] Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • [NA] Documentation needed
      • [NA] Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

This change is Reviewable

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Autofix SA1518: The code must not contain blank lines at the end of t…
67015b8 
…he file
@xtqqczze
xtqqczze requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners September 4, 2020 13:39
@ghost ghost assigned Ilya (iSazonov) Sep 4, 2020
iSazonov
Ilya (iSazonov) approved these changes Sep 4, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log size/XL Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers labels Sep 4, 2020
@ghost

Deleted user (ghost) commented Sep 12, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 12, 2020
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 15, 2020

Copy link
Copy Markdown
Member

@PowerShell/powershell-maintainers reviewed this PR and agreed to reject it. We have been telling contributors to add a new line at the end for quite some time, because GitHub code difference usually complains about not having a new line at the end.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) closed this Sep 15, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Sep 15, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 15, 2020
@xtqqczze

xtqqczze commented Sep 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) According to the documentation for SA1518, the default setting for this rule is: "Files are allowed to end with a single newline character, but it is not required".

To be clear, while this PR removes the necessary blank lines at the the of files, it does not remove the single newline charactor at the end of the last line (which may in fact cause issues with diff tools).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Sep 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw) The PR removes extra second empty line at EOF.
xtqqczze reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Steg17
Steg17 reviewed Sep 16, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/AddContentCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Please reopen.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) reopened this Oct 13, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 20, 2020
@ghost

Deleted user (ghost) commented Oct 20, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) The PR remove extra second empty line at EOF.

Dongbo Wang (@daxian-dbw) Can you please re-review, I would like this merged early for 7.2.0-preview.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 21, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 28, 2020
@ghost

Deleted user (ghost) commented Oct 28, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) reviewed Oct 28, 2020
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 57 files

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 28, 2020

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 7 days
PoshChan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 28, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 5, 2020
@ghost

Deleted user (ghost) commented Nov 5, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Please continue your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
iSazonov
Ilya (iSazonov) approved these changes Nov 11, 2020
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 4d2965a into PowerShell:master Nov 11, 2020
@iSazonov Ilya (iSazonov) changed the title Autofix SA1518: No blank lines at the end of the file Autofix SA1518: No extra blank lines at the end of the file Nov 11, 2020
@xtqqczze
xtqqczze deleted the SA1518 branch November 11, 2020 17:39
@xtqqczze xtqqczze mentioned this pull request Nov 11, 2020
Add StyleCop.Analyzers package #13963
Merged
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze mentioned this pull request Sep 3, 2025
Ensure .cs files end with exactly one newline #25968
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Autofix SA1518: The code must not contain extra blank lines at the en…
6344d5a 
…d of the file (PowerShell#13574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
+1 more reviewer
@Steg17 Steg17 Steg17 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log size/XL

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@xtqqczze @daxian-dbw @iSazonov @TravisEz13 @Steg17
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.