GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Add `-SkipLimitCheck` switch to `Import-PowerShellDataFile` by SteveL-MSFT · Pull Request #13672 · PowerShell/PowerShell Conversation
|
|
Shouldn't this follow the JSON cmdlet's |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
But I do think following a similar pattern is probably a better call than a switch; if a user knows the ballpark value to use, let them specify 1000 or 2000 so they can keep some control over the input file and verify things aren't getting input over and above what they expected. Have it default to 500 and then if you really want no limit, set it to zero or something? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
0 or -1 both seem logical to me |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
-NoLimit switch to Import-PowerShellDataFile-SkipLimitCheck switch to Import-PowerShellDataFile
|
I think |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Tests LGTM. Small suggestion on the param name
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
The static analysis credscan issue is fixed as part of #13692 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a918136 to
197ffa1
Compare
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) Please update the PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…hell.Utility.psd1 Co-authored-by: Aditya Patwardhan <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Aditya Patwardhan (@adityapatwardhan)'s suggestion applied
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
PoshChan-Bot (@PoshChan) please remind me in 18 hours |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Rob Holt (@rjmholt), this is the reminder you requested 18 hours ago |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Requested changes have been made
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Import-PowerShellDataFile Errors on files over 3230 lines
There was an error while loading. Please reload this page.