GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix nullable usage on displayDescriptionData_Table.cs by mkswd · Pull Request #13808 · PowerShell/PowerShell

Conversation

@mkswd

@mkswd Marcos Ramos (mkswd) commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Changed nullable usage for better implementation.
Change in displayDescriptionData_Table.cs

PR Context

Change has done due to issue #13791

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Marcos Ramos
fixed nullable usage on displayDescriptionData_Table.cs
b05f10a
@ghost ghost assigned Dongbo Wang (daxian-dbw) Oct 17, 2020
iSazonov
Ilya (iSazonov) approved these changes Oct 19, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) assigned Rob Holt (rjmholt) Oct 19, 2020
@iSazonov Ilya (iSazonov) added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Hacktoberfest-Accepted Accepted to participate in Hacktoberfest labels Oct 19, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 26, 2020
@ghost

Deleted user (ghost) commented Oct 26, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt
Rob Holt (rjmholt) merged commit 60a8fa3 into PowerShell:master Nov 10, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 10, 2020
This was referenced Nov 17, 2020
Fix nullable usage on authenticode (#13791) #13804
Merged
Use Nullable<T>.GetValueOrDefault() #13791
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@mkswd
Fix nullable usage on displayDescriptionData_Table.cs (PowerShell#13808)
530809b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Hacktoberfest-Accepted Accepted to participate in Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mkswd @iSazonov @daxian-dbw @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.