GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add position 0 to Write-Error parameters by ThomasNieto · Pull Request #13813 · PowerShell/PowerShell

Conversation

@ThomasNieto

@ThomasNieto Thomas Nieto (ThomasNieto) commented Oct 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Add Position = 0 to Write-Error to Exception and ErrorRecord parameters.

PR Context

Resolves #10739

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Write-Error Position 0 for parameters MicrosoftDocs/PowerShell-Docs#6771
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost assigned Travis Plunk (TravisEz13) Oct 19, 2020
iSazonov
Ilya (iSazonov) approved these changes Oct 19, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Oct 19, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Thomas Nieto (@ThomasNieto) Please open new issue for 7.2 version in PowerShell-Docs repo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added Documentation Needed in this repo Documentation is needed in this repo CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Hacktoberfest-Accepted Accepted to participate in Hacktoberfest labels Oct 19, 2020
@ThomasNieto Thomas Nieto (ThomasNieto) mentioned this pull request Oct 19, 2020
Write-Error Position 0 for parameters MicrosoftDocs/PowerShell-Docs#6771
Closed
@iSazonov Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Oct 20, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 27, 2020
@ghost

Deleted user (ghost) commented Oct 27, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 15, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

Thomas Nieto (@ThomasNieto) Please resolve merge conflicts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 16, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020
@ghost

Deleted user (ghost) commented Dec 23, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

Thomas Nieto (@ThomasNieto) Please resolve merge conflicts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021
@ghost

Deleted user (ghost) commented Jan 16, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thomas Nieto (ThomasNieto) added 2 commits July 21, 2021 15:42
@ThomasNieto @SteveL-MSFT
Add position 0 to parameters
e138a5c
@ThomasNieto @SteveL-MSFT
Add parameter position 0 tests
162ffaa
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the write_error_position_0 branch from 2ab1bbe to 162ffaa Compare July 21, 2021 22:42
@SteveL-MSFT Steve Lee (SteveL-MSFT) removed the Review - Needed The PR is being reviewed label Jul 21, 2021
@TravisEz13
Travis Plunk (TravisEz13) merged commit 05943c6 into PowerShell:master Jul 22, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.8 milestone Jul 22, 2021
@ghost

Deleted user (ghost) commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Aug 23, 2021
Write-Error should use positional binding to -ErrorRecord and -Exception #10739
Closed
@ghost

Deleted user (ghost) commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@ThomasNieto
Add position 0 to Write-Error parameters (PowerShell#13813)
178d412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Hacktoberfest-Accepted Accepted to participate in Hacktoberfest

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

Write-Error should use positional binding to -ErrorRecord and -Exception

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ThomasNieto @iSazonov @SteveL-MSFT @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.