GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix IDE0044: MakeFieldReadonly part 10 by xtqqczze · Pull Request #13893 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044

Split from #13880 to ease review.

test\

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Fix IDE0044: MakeFieldReadonly part 10
f8aee56 
test\
@ghost ghost assigned Ilya (iSazonov) Oct 26, 2020
@iSazonov
Ilya (iSazonov) requested review from Aditya Patwardhan (adityapatwardhan) and Rob Holt (rjmholt) October 26, 2020 17:32
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 26, 2020
iSazonov
Ilya (iSazonov) reviewed Oct 29, 2020
View reviewed changes
Comment thread test/xUnit/csharp/test_Runspace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Oct 30, 2020
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit a2a938e into PowerShell:master Oct 30, 2020
@xtqqczze
xtqqczze deleted the IDE0044-p10 branch October 30, 2020 14:52
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 30, 2020
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix IDE0044: MakeFieldReadonly part 10 (PowerShell#13893)
39d07a7 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xtqqczze @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.