GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable IDE0048: AddRequiredParentheses by xtqqczze · Pull Request #13896 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Enable IDE0048: AddRequiredParentheses
4ebaa40 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Oct 26, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review October 27, 2020 15:06
@iSazonov

Ilya (iSazonov) commented Oct 29, 2020

Copy link
Copy Markdown
Collaborator

Default is always_for_clarity for arithmetic, relational, and other binary operators.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Oct 29, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 29, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Aditya Patwardhan (adityapatwardhan) Oct 29, 2020
@iSazonov
Ilya (iSazonov) merged commit 83a3f53 into PowerShell:master Oct 29, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Oct 29, 2020
@xtqqczze
xtqqczze deleted the IDE0048 branch October 29, 2020 14:25
@xtqqczze xtqqczze mentioned this pull request Oct 29, 2020
Enable IDE0048: AddRequiredParentheses #13936
Closed
@xtqqczze

xtqqczze commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

This PR did not fix all IDE0048 violations, see #13936. Since the severity was set to warning, the build should not have completed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

Is it a bug in the Roslyn analyzer?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze restored the IDE0048 branch October 30, 2020 14:07
@xtqqczze
xtqqczze deleted the IDE0048 branch November 2, 2020 03:51
@xtqqczze

xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Is it a bug in the Roslyn analyzer?

No EnforceCodeStyleInBuild was not enabled.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable IDE0048: AddRequiredParentheses (PowerShell#13896)
e1490d2 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0047-ide0048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.