GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable CA1830: Prefer strongly-typed Append and Insert method overloads on StringBuilder by xtqqczze · Pull Request #13926 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Oct 29, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review October 29, 2020 18:18
@xtqqczze

xtqqczze commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Can you approve?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Oct 30, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 30, 2020
@xtqqczze
Enable CA1830: Prefer strongly-typed Append and Insert method overloa…
fc08614 
…ds on StringBuilder

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
@xtqqczze
xtqqczze force-pushed the CA1830 branch from 89d3bda to fc08614 Compare October 30, 2020 14:31
@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze

xtqqczze commented Oct 30, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Please restart tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) closed this Oct 30, 2020
@iSazonov Ilya (iSazonov) reopened this Oct 30, 2020
@iSazonov

Ilya (iSazonov) commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

Reopen the PR to restart all CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

This comment has been minimized.

Sign in to view
@xtqqczze

xtqqczze commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

closing and reopening to restart tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Oct 31, 2020
@xtqqczze xtqqczze reopened this Oct 31, 2020
@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Aditya Patwardhan (adityapatwardhan) Nov 2, 2020
@iSazonov
Ilya (iSazonov) merged commit 4b9f9dc into PowerShell:master Nov 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 2, 2020
@xtqqczze
xtqqczze deleted the CA1830 branch November 2, 2020 03:49
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable CA1830: Prefer strongly-typed Append and Insert method overloa…
0f7ada5 
…ds on StringBuilder (PowerShell#13926)

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.