GeezerVison

Ilya (@iSazonov) Can you merge?

No, we should inform users to use right header. We need to set "suggestion". Or we could suppress the rule for some files/folders.

Ilya (@iSazonov) We cannot use directory based suppression, at least for src\System.Management.Automation\engine\interpreter\ as there are files with different licenses present in the same directory.

For suggestion severity, I worry that it would be too easy for a contributor to accidentally accept a light bulb recommendation in an existing file, resulting in a change in the license header! If we were to set suggestion, I would want maintainer review of this change.

For suggestion severity, I worry that it would be too easy for a contributor to accidentally accept a light bulb recommendation in an existing file, resulting in a change in the license header!

It is not problem. We have some files from other repositories with different licenses and the files are frozen. We know about this. So "suggestion" is good compromise.

For suggestion severity, I worry that it would be too easy for a contributor to accidentally accept a light bulb recommendation in an existing file, resulting in a change in the license header!

It is not problem. We have some files from other repositories with different licenses and the files are frozen. We know about this. So "suggestion" is good compromise.

OK

Ilya (@iSazonov) Are there any options for suppression on a per file basis, other than the following?

#pragma warning disable IDE0073 // The file header does not match the required text
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
#pragma warning restore IDE0073 // The file header does not match the required text

The example above is for the file: src\System.Management.Automation\engine\ComInterop\ArgBuilder.cs.

xtqqczze The case is so rare and not critical so we can use "suggestion" without any concerns - maintainer will review and ensure.

Reopen the PR to restart all CIs.

Build failures are due to PowerShell Gallery unavailability, see #13946.

closing and reopening to restart tests

I wonder before the change we have "warning" but build does not fail.

It appears that IDE0073 is only triggering in live analysis, not in build. We need to set MSBuild property EnforceCodeStyleInBuild.

Change was merged in #13957.