GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enforce code style in build by xtqqczze · Pull Request #13957 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Enable EnforceCodeStyleInBuild
  • Disable IDE0048 due to rule violations (see also: Enable IDE0048: AddRequiredParentheses #13936)
  • Disable IDE0073 due to rule violations (see also: Disable IDE0073: FileHeaderMismatch #13935)
  • Disable IDE0036: due to rule violations (see also: Enable IDE0036: OrderModifiers #13958)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits October 31, 2020 16:56
@xtqqczze
Enable EnforceCodeStyleInBuild
5f5c6d8
@xtqqczze
Disable rules breaking build
fb29f19
@xtqqczze
xtqqczze requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 31, 2020 17:03
@ghost ghost assigned Ilya (iSazonov) Oct 31, 2020
@xtqqczze
Disable IDE0036
d61221c
@xtqqczze

xtqqczze commented Oct 31, 2020

Copy link
Copy Markdown
Contributor Author

/home/vsts/work/1/s/src/powershell/Program.cs(505,9): error IDE0036: Modifiers are not ordered [/home/vsts/work/1/s/src/powershell-unix/powershell-unix.csproj]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze mentioned this pull request Oct 31, 2020
Enable IDE0036: OrderModifiers #13958
Merged
iSazonov
Ilya (iSazonov) approved these changes Nov 1, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 1, 2020
@iSazonov
Ilya (iSazonov) merged commit ea4cf93 into PowerShell:master Nov 1, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 1, 2020
@xtqqczze
xtqqczze deleted the EnforceCodeStyleInBuild branch November 1, 2020 16:44
@xtqqczze xtqqczze mentioned this pull request Nov 1, 2020
Disable IDE0073: FileHeaderMismatch #13935
Closed
@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you review #13936 and #13958?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze mentioned this pull request Nov 1, 2020
Enable IDE0048: AddRequiredParentheses #13936
Closed
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enforce code style in build (PowerShell#13957)
f4007eb 
* Enable EnforceCodeStyleInBuild

* Disable rules breaking build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xtqqczze @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.