GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add IDE analyzer rule IDs to comments by xtqqczze · Pull Request #13960 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follow-up to #13835.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Dongbo Wang (daxian-dbw) Nov 1, 2020
@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-static-analysis failure caused by transient network issues.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kilasuit

Ryan Yates (kilasuit) commented Nov 1, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze can you add a description to this PR as right now this to me doesn't explain why this should be merged, there is no link to an issue etc so there is no context to this PR other than what is in files changed - a recommended best practice for when raising a PR
xtqqczze reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 2, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Add IDE analyzer rule IDs to comments
eb8c5c8
@xtqqczze
xtqqczze force-pushed the globalconfig-comments branch from 3213040 to eb8c5c8 Compare November 2, 2020 03:48
@xtqqczze

xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) rebased, can you merge soon to avoid more merge conflicts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Nov 2, 2020
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 2, 2020
@iSazonov
Ilya (iSazonov) merged commit 329d6b4 into PowerShell:master Nov 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 2, 2020
@xtqqczze
xtqqczze deleted the globalconfig-comments branch November 2, 2020 10:18
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Add IDE analyzer rule IDs to comments (PowerShell#13960)
5061eb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @kilasuit @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.