GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable IDE0040: AddAccessibilityModifiers by xtqqczze · Pull Request #13962 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Rob Holt (rjmholt) Nov 1, 2020
@xtqqczze xtqqczze changed the title WIP: Enable IDE0040: AddAccessibilityModifiers Enable IDE0040: AddAccessibilityModifiers Nov 2, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review November 2, 2020 02:33
@xtqqczze
xtqqczze requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 2, 2020 02:33
@xtqqczze
Enable IDE0040: AddAccessibilityModifiers
4fa7baf 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
@xtqqczze
xtqqczze force-pushed the IDE0040 branch from 62b1df2 to 4fa7baf Compare November 2, 2020 11:58
iSazonov
Ilya (iSazonov) approved these changes Nov 5, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xtqqczze added 2 commits November 6, 2020 18:25
@xtqqczze
Merge branch 'master' into IDE0040
3db097d
@xtqqczze
Fix whitespace
eca52b9
@xtqqczze

xtqqczze commented Nov 6, 2020

Copy link
Copy Markdown
Contributor Author

Merge conflicts resolved.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 8, 2020
View reviewed changes
iSazonov
Ilya (iSazonov) reviewed Nov 8, 2020
View reviewed changes
Comment thread test/tools/TestService/Program.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Nov 8, 2020
View reviewed changes
Comment thread test/tools/TestExe/TestExe.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 9, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Rob Holt (rjmholt) Nov 9, 2020
@iSazonov
Ilya (iSazonov) merged commit 23deb41 into PowerShell:master Nov 9, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 9, 2020
@xtqqczze
xtqqczze deleted the IDE0040 branch November 9, 2020 14:18
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable IDE0040: AddAccessibilityModifiers (PowerShell#13962)
5a063bd 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.