GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix RCS1049: Simplify boolean comparison by xtqqczze · Pull Request #13994 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

This PR includes changes to ComInterop that have also been made in dotnet/runtime#44564.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Fix RCS1049: Simplify boolean comparison
c5b89f0 
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md
@xtqqczze
xtqqczze requested a review from Dongbo Wang (daxian-dbw) as a code owner November 6, 2020 03:22
@ghost ghost assigned Dongbo Wang (daxian-dbw) Nov 6, 2020
iSazonov
Ilya (iSazonov) reviewed Nov 6, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Nov 6, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost

Deleted user (ghost) commented Nov 6, 2020

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 6, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 6, 2020
Code redundancy fixes pass 2 #13334
Closed
@iSazonov
Ilya (iSazonov) requested a review from Travis Plunk (TravisEz13) November 6, 2020 17:16
@xtqqczze @iSazonov
Apply suggestions from code review
e5bd094 
Co-authored-by: Ilya <[email protected]>
iSazonov
Ilya (iSazonov) approved these changes Nov 7, 2020
View reviewed changes
@xtqqczze

xtqqczze commented Nov 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

This PR makes changes to ComInterop, so a corresponding PR has been opened at dotnet/runtime#44564.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

dotnet/runtime#44564 is approved.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 12, 2020
View reviewed changes
@xtqqczze

xtqqczze commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

dotnet/runtime#44564 is merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) self-assigned this Nov 13, 2020
@iSazonov
Ilya (iSazonov) merged commit b521b85 into PowerShell:master Nov 13, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 13, 2020
@xtqqczze
xtqqczze deleted the RCS1049 branch November 13, 2020 05:31
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix RCS1049: Simplify boolean comparison (PowerShell#13994)
c31c4e2 
* Fix RCS1049: Simplify boolean comparison

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

Related dotnet/runtime#44564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.