GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate 3rd party signing to ESRP by TravisEz13 · Pull Request #14010 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Nov 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Migrate 3rd party signing

  • Update 1st party signing

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Travis Plunk (TravisEz13) added 2 commits November 6, 2020 14:28
@TravisEz13
Move 3rd party signing to ESRP
24053d1
@TravisEz13
Add unsigned powershell files
2f941f9
@ghost ghost assigned Rob Holt (rjmholt) Nov 8, 2020
Travis Plunk (TravisEz13) added 2 commits November 8, 2020 13:40
@TravisEz13
remove comment
cb4eea3
@TravisEz13
use hosted machine
2df660d
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review November 10, 2020 17:12
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 10, 2020 17:12
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Consider labels Nov 10, 2020
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Nov 10, 2020
View reviewed changes
rjmholt
Rob Holt (rjmholt) reviewed Nov 10, 2020
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/templates/windows-packaging.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 @rjmholt
Update tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
72ac3fa
Co-authored-by: Robert Holt <[email protected]>
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 11, 2020
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 11, 2020
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost

Deleted user (ghost) commented Nov 11, 2020

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost

Deleted user (ghost) commented Nov 11, 2020

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 5fd45ea into PowerShell:master Nov 11, 2020
@TravisEz13
Travis Plunk (TravisEz13) deleted the more-esrp branch November 11, 2020 20:09
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost

Deleted user (ghost) commented Nov 17, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Approved and removed BackPort-7.0.x-Consider labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13 @rjmholt
Migrate 3rd party signing to ESRP (#14010)
ca79a9b
Co-authored-by: Robert Holt <[email protected]>
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13
Migrate 3rd party signing to ESRP (#14010)
bf10566
Co-authored-by: Robert Holt <[email protected]>
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.0.x-Done and removed BackPort-7.0.x-Approved labels Dec 17, 2020
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShell that referenced this pull request Jan 12, 2021
@TravisEz13
Migrate 3rd party signing to ESRP (PowerShell#14010)
9e07586
Co-authored-by: Robert Holt <[email protected]>
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-packaging.yml
@ghost

Deleted user (ghost) commented Jan 14, 2021

Copy link
Copy Markdown

🎉v7.1.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Jan 19, 2021

Copy link
Copy Markdown

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13 @rjmholt
Migrate 3rd party signing to ESRP (PowerShell#14010)
9293616
Co-authored-by: Robert Holt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @daxian-dbw @rjmholt @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.