GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert changes to ComInterop by xtqqczze · Pull Request #14012 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

According to #13880 (comment) code in src/System.Management.Automation/engine/ComInterop/ comes from dotnet/runtime and should be frozen.

But in #13967 (part of #13880) we made changes to fix IDE0044: Add readonly modifier.

So this PR reverts these changes and disables code analyzers in this directory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits November 8, 2020 23:25
@xtqqczze
Revert changes to ComInterop
33fc384 
src/System.Management.Automation/engine/ComInterop/
@xtqqczze
Disable code analysis in ComInterop
74258de
@ghost ghost assigned Travis Plunk (TravisEz13) Nov 8, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 8, 2020
Enable IDE0044: MakeFieldReadonly #13880
Merged
iSazonov
Ilya (iSazonov) approved these changes Nov 9, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 9, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Nov 9, 2020
@iSazonov
Ilya (iSazonov) merged commit ed595c0 into PowerShell:master Nov 9, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 9, 2020
@xtqqczze
xtqqczze deleted the revert-IDE0044-ComInterop branch November 9, 2020 14:17
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Revert changes to ComInterop (PowerShell#14012)
fe6b485 
* Revert changes to ComInterop

src/System.Management.Automation/engine/ComInterop/

* Disable code analysis in ComInterop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.