GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable nullable: System.Management.Automation.Internal.IValidateSetValuesGenerator by xtqqczze · Pull Request #14018 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Tracking issue: #12631.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Enable nullable: System.Management.Automation.Internal.IValidateSetVa…
d71d0df 
…luesGenerator
@ghost ghost assigned Dongbo Wang (daxian-dbw) Nov 9, 2020
xtqqczze
xtqqczze commented Nov 9, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/Attributes.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Nov 9, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/Attributes.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze mentioned this pull request Nov 9, 2020
Nullable annotations #12631
Closed
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT), Dongbo Wang (daxian-dbw) and Rob Holt (rjmholt) November 9, 2020 18:22
rjmholt
Rob Holt (rjmholt) approved these changes Nov 10, 2020
View reviewed changes
@xtqqczze
Add documentation comment for return type
4c2706c 
Address @iSazonov review
@xtqqczze

xtqqczze commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

Added documentation comment: <returns>A non-null array of non-null strings.</returns>
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze requested a review from Rob Holt (rjmholt) November 11, 2020 03:41
iSazonov
Ilya (iSazonov) approved these changes Nov 11, 2020
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit f6caf2d into PowerShell:master Nov 13, 2020
@iSazonov

Ilya (iSazonov) commented Nov 13, 2020

Copy link
Copy Markdown
Collaborator

Great start! :-)
xtqqczze reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 13, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 13, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Nov 13, 2020
@xtqqczze
xtqqczze deleted the nullable-IValidateSetValuesGenerator branch November 13, 2020 05:53
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable nullable: System.Management.Automation.Internal.IValidateSetVa…
bf45c9c 
…luesGenerator (PowerShell#14018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
+1 more reviewer
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@xtqqczze @iSazonov @rjmholt @vexx32 @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.