GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move windows package signing to use ESRP by TravisEz13 · Pull Request #14060 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Nov 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Move windows package signing to use ESRP

  • Use hosted windows pool

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Travis Plunk (TravisEz13) added 6 commits November 11, 2020 12:15
@TravisEz13
use hosted pool
ce1bf62
@TravisEz13
move win package signing to ESRP
9e67d33
@TravisEz13
Move to ESRP scanning
56d4b5f
@TravisEz13
add variable group
930cca3
@TravisEz13
REVERT: switch to feature compliance branch
38e3ff0
@TravisEz13
Fix scanning
4d19b12
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Nov 12, 2020
TravisEz13
Travis Plunk (TravisEz13) commented Nov 12, 2020
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/releaseBuild.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Update tools/releaseBuild/azureDevOps/releaseBuild.yml
cc463a6
@TravisEz13 Travis Plunk (TravisEz13) changed the title More esrp 2 Move windows package signing to use ESRP Nov 12, 2020
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review November 12, 2020 18:48
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 12, 2020 18:48
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Nov 12, 2020
View reviewed changes
Comment thread tools/releaseBuild/azureDevOps/releaseBuild.yml
type: github
endpoint: ComplianceGHRepo
name: PowerShell/compliance
ref: master

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Nov 12, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the default and it needs to be in ref/heads/master format
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/resources?view=azure-devops&tabs=schema#resources-repositories

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@TravisEz13 Travis Plunk (TravisEz13) Nov 12, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch name works and I'm contantly having to add and remove this. I'd like to keep it for easier testing, and returning it back to it's default.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@TravisEz13 Travis Plunk (TravisEz13) Nov 12, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commit: cc463a6 (#14060)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 12, 2020
rjmholt
Rob Holt (rjmholt) approved these changes Nov 12, 2020
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 13, 2020
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit d7ecf45 into PowerShell:master Nov 13, 2020
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 13, 2020
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added this to the 7.2.0-preview.2 milestone Nov 13, 2020
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Approved labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13
Move windows package signing to use ESRP (#14060)
296bde1
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13
Move windows package signing to use ESRP (#14060)
ec44734
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
@TravisEz13 Travis Plunk (TravisEz13) added the Backport-7.0.x-Done label Dec 17, 2020
@TravisEz13 Travis Plunk (TravisEz13) removed the BackPort-7.0.x-Approved label Dec 17, 2020
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShell that referenced this pull request Jan 12, 2021
@TravisEz13
Move windows package signing to use ESRP (PowerShell#14060)
ce47a53
# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml

# Conflicts:
#	tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml
@ghost

Deleted user (ghost) commented Jan 14, 2021

Copy link
Copy Markdown

🎉v7.1.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Jan 19, 2021

Copy link
Copy Markdown

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) deleted the more-esrp-2 branch September 2, 2021 18:28
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Move windows package signing to use ESRP (PowerShell#14060)
b294c4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @rjmholt @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.