GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable IDE0075: SimplifyConditionalExpression by xtqqczze · Pull Request #14078 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Ilya (iSazonov) Nov 13, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@ghost ghost added the Stale label Dec 1, 2020
@ghost

Deleted user (ghost) commented Dec 1, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
xtqqczze force-pushed the IDE0075 branch from b7ea3db to 04977c9 Compare December 1, 2020 09:10
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Dec 1, 2020
xtqqczze added 3 commits December 1, 2020 09:14
@xtqqczze
Enable IDE0075: SimplifyConditionalExpression
c8c1999 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0075
@xtqqczze
Fix formatting
e5a1969
@xtqqczze
Remove unnecessary parenthesis
16136e9
@xtqqczze
xtqqczze force-pushed the IDE0075 branch from 04977c9 to 16136e9 Compare December 1, 2020 09:16
@xtqqczze
xtqqczze marked this pull request as ready for review December 1, 2020 10:29
@xtqqczze
xtqqczze requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 1, 2020 10:29
iSazonov
Ilya (iSazonov) reviewed Dec 1, 2020
View reviewed changes
Comment thread src/System.Management.Automation/FormatAndOutput/common/FormattingObjectsDeserializer.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/client/ClientMethodExecutor.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/client/Job.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/remoting/server/ServerRemoteHost.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 1, 2020
xtqqczze and others added 2 commits December 1, 2020 15:29
@xtqqczze @iSazonov
Apply suggestions from code review
87fb236 
Remove unnecessary parenthesis.

Co-authored-by: Ilya <[email protected]>
@xtqqczze
Fix formatting
a894572
iSazonov
Ilya (iSazonov) reviewed Dec 1, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/GetCommandCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Dec 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Ae you happy to merge as-is, or do you want more changes to remove redundant parenthesis?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Dec 2, 2020
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 18717c5 into PowerShell:master Dec 2, 2020
@xtqqczze xtqqczze mentioned this pull request Dec 2, 2020
Use Microsoft.PowerShell.MarkdownRender package from nuget.org #14090
Merged
8 of 14 tasks
@xtqqczze
xtqqczze deleted the IDE0075 branch December 2, 2020 10:28
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Jan 27, 2021
GCI of extended-length path "\\?\" returns incorrect items #14668
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable IDE0075: SimplifyConditionalExpression (PowerShell#14078)
b254a75 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@xtqqczze @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.