GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable CA2216: Disposable types should declare finalizer by xtqqczze · Pull Request #14089 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2216

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Enable CA2216: Disposable types should declare finalizer
88828b6 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2216
@ghost ghost assigned Dongbo Wang (daxian-dbw) Nov 13, 2020
@xtqqczze

xtqqczze commented Nov 14, 2020

Copy link
Copy Markdown
Contributor Author

restarting tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Nov 14, 2020
@xtqqczze xtqqczze reopened this Nov 14, 2020
@xtqqczze

xtqqczze commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

Test failures fixed by #14094, waiting for #14101 to restart tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 16, 2020

Copy link
Copy Markdown
Contributor Author

restarting tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Nov 16, 2020
@xtqqczze xtqqczze reopened this Nov 16, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review November 17, 2020 11:47
iSazonov
Ilya (iSazonov) approved these changes Nov 21, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 21, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Nov 21, 2020
@iSazonov
Ilya (iSazonov) merged commit 8691607 into PowerShell:master Nov 21, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 21, 2020
@xtqqczze
xtqqczze deleted the CA2216 branch November 21, 2020 23:09
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable CA2216: Disposable types should declare finalizer (PowerShell#…
6d38a82 
…14089)

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.