GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix whitespace issues by xtqqczze · Pull Request #14092 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 14, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix some whitespace issues using dotnet-format

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
xtqqczze requested a review from Andrew (anmenaga) as a code owner November 14, 2020 01:47
@ghost ghost assigned Travis Plunk (TravisEz13) Nov 14, 2020
@xtqqczze

xtqqczze commented Nov 14, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Please could you merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 14, 2020

Copy link
Copy Markdown
Contributor Author

Test failures due to HTTP error 503 (Service Unavailable) in package restore. Since these are trivial changes, I will not restart tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 14, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Nov 14, 2020 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

GitHub
iSazonov/PowerShell
PowerShell for every system! Contribute to iSazonov/PowerShell development by creating an account on GitHub.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Nov 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

Fix merged in #14094.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 16, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Fix whitespace issues
f3ae5ab
@xtqqczze
xtqqczze force-pushed the fix-whitespace branch from 32f3eb4 to f3ae5ab Compare November 16, 2020 03:30
@xtqqczze

xtqqczze commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Pleases merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Nov 19, 2020
@iSazonov
Ilya (iSazonov) merged commit c9df1c1 into PowerShell:master Nov 19, 2020
@xtqqczze
xtqqczze deleted the fix-whitespace branch November 19, 2020 11:44
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix whitespace issues (PowerShell#14092)
3327005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.