GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix SA1642 for Microsoft.PowerShell.Commands.Utility by xtqqczze · Pull Request #14142 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

Fix SA1642: Constructor summary documentation should begin with standard text for Microsoft.PowerShell.Commands.Utility.

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1642.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Fix SA1642 for Microsoft.PowerShell.Commands.Utility
65077bc
@ghost ghost assigned Travis Plunk (TravisEz13) Nov 19, 2020
@xtqqczze
xtqqczze force-pushed the SA1642-p1 branch from 24888ad to f9dd738 Compare November 19, 2020 14:03
iSazonov
Ilya (iSazonov) approved these changes Nov 19, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ObjectCommandComparer.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) self-requested a review November 19, 2020 15:16
xtqqczze
xtqqczze commented Nov 19, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ObjectCommandComparer.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please see CI fails.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Replace summary text
6c6ad6d
@xtqqczze
xtqqczze force-pushed the SA1642-p1 branch from f9dd738 to 97de5a9 Compare November 20, 2020 12:27
@xtqqczze

xtqqczze commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

xtqqczze Please see CI fails.

I accidentally committed dotnet_diagnostic.SA1642.severity = warning.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 20, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
iSazonov
Ilya (iSazonov) approved these changes Nov 20, 2020
View reviewed changes
@xtqqczze
xtqqczze force-pushed the SA1642-p1 branch from 97de5a9 to 6c6ad6d Compare November 20, 2020 17:04
@xtqqczze

xtqqczze commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

I have removed TODO commit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) merged commit ca21c7c into PowerShell:master Nov 21, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 21, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Nov 21, 2020
@xtqqczze
xtqqczze deleted the SA1642-p1 branch November 21, 2020 23:28
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix SA1642 for Microsoft.PowerShell.Commands.Utility (PowerShell#14142)
a2d107e 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1642.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.