GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable nullable: System.Management.Automation.Language.IAstPostVisitHandler by powercode · Pull Request #14164 · PowerShell/PowerShell

Conversation

@powercode

@powercode Staffan Gustafsson (powercode) commented Nov 19, 2020

Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@powercode
Enable nullable: System.Management.Automation.Language.IAstPostVisitH…
30f26b4 
…andler
@powercode
Staffan Gustafsson (powercode) requested a review from Dongbo Wang (daxian-dbw) as a code owner November 19, 2020 22:43
@ghost ghost assigned Rob Holt (rjmholt) Nov 19, 2020
rjmholt
Rob Holt (rjmholt) approved these changes Nov 20, 2020
View reviewed changes
@rjmholt

Rob Holt (rjmholt) commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 1 day
PoshChan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Staffan Gustafsson (powercode) added 2 commits November 20, 2020 18:52
@powercode
Removing whitespace before/after nullable pragma
d36d102
@powercode
Removing whitespace before/after nullable pragma
934de9c
@PoshChan

PoshChan-Bot (PoshChan) commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt), this is the reminder you requested 1 day ago
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost

Deleted user (ghost) commented Nov 28, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt

Rob Holt (rjmholt) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

Staffan Gustafsson (@powercode) looks like the build is failing due to changes in this PR:

/home/vsts/work/1/s/src/System.Management.Automation/engine/parser/PreOrderVisitor.cs(252,1): error SA1507: Code should not contain multiple blank lines in a row [/home/vsts/work/1/s/src/System.Management.Automation/System.Management.Automation.csproj]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 9, 2020
rjmholt
Rob Holt (rjmholt) reviewed Dec 9, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/parser/PreOrderVisitor.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Update src/System.Management.Automation/engine/parser/PreOrderVisitor.cs
fd777be
@rjmholt

Rob Holt (rjmholt) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 1 hour
PoshChan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Rob Holt (rjmholt) merged commit 9724293 into PowerShell:master Dec 9, 2020
@PoshChan

PoshChan-Bot (PoshChan) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt), this is the reminder you requested 1 hour ago
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 11, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@powercode
Staffan Gustafsson (powercode) deleted the nullable/IAstPostVisitHandler branch December 16, 2020 08:31
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@powercode
Enable nullable: System.Management.Automation.Language.IAstPostVisitH…
c485871 
…andler (PowerShell#14164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@powercode @rjmholt @PoshChan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.