GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix SA1119: Statement should not use unnecessary parenthesis part 1 by xtqqczze · Pull Request #14204 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

src\Microsoft.Management.Infrastructure.CimCmdlets\

Contributes to "Enable SA1119: Statement should not use unnecessary parenthesis" (#14133).

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1119.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
xtqqczze requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 20, 2020 13:57
@ghost ghost assigned Travis Plunk (TravisEz13) Nov 20, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 20, 2020
Enable SA1119: Statement should not use unnecessary parenthesis #14133
Closed
@xtqqczze xtqqczze changed the title Fix SA1119 part 1 Fix SA1119 Statement should not use unnecessary parenthesis part 1 Nov 20, 2020
@xtqqczze xtqqczze changed the title Fix SA1119 Statement should not use unnecessary parenthesis part 1 Fix SA1119: Statement should not use unnecessary parenthesis part 1 Nov 20, 2020
@iSazonov

Ilya (iSazonov) commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

Please split the PR on 3-4-5 PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost

Deleted user (ghost) commented Nov 28, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
Fix SA1119 part 1
a65fbb2
@xtqqczze
xtqqczze force-pushed the SA1119-p1 branch from 7864257 to a65fbb2 Compare November 30, 2020 17:37
@xtqqczze

xtqqczze commented Nov 30, 2020

Copy link
Copy Markdown
Contributor Author

Please split the PR on 3-4-5 PRs.

OK
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Dec 8, 2020
@xtqqczze xtqqczze reopened this Dec 8, 2020
iSazonov
Ilya (iSazonov) approved these changes Dec 9, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 9, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov
Ilya (iSazonov) merged commit bb55515 into PowerShell:master Jan 9, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 9, 2021
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix SA1119 part 1 (PowerShell#14204)
230ed03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.