GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Code performance fixes follow-up by xtqqczze · Pull Request #14207 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follow-up to #12956

  • Fix RCS1080: Use 'Count/Length' property instead of 'Any' method
  • Fix RCS1235: Optimize method call

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits November 20, 2020 15:12
@xtqqczze
Fix RCS1080: Use 'Count/Length' property instead of 'Any' method
d8147a2 
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1080.md
@xtqqczze
Fix RCS1235: Optimize method call
a62f5d3 
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1235.md
@xtqqczze
xtqqczze requested a review from Dongbo Wang (daxian-dbw) as a code owner November 20, 2020 15:15
@ghost ghost assigned Andrew (anmenaga) Nov 20, 2020
iSazonov
Ilya (iSazonov) reviewed Nov 20, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/parser/AstVisitor.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Nov 20, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@anmenaga
Andrew (anmenaga) merged commit fcafb7f into PowerShell:master Nov 20, 2020
@xtqqczze
xtqqczze deleted the RCS-perf2 branch November 21, 2020 00:03
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Code performance fixes follow-up (PowerShell#14207)
f05da22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.