GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable SA1504: All accessors should be single-line or multi-line by xtqqczze · Pull Request #14241 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Dongbo Wang (daxian-dbw) Nov 23, 2020
@xtqqczze

xtqqczze commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

Depends on #14243.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze changed the title Enable SA1504: All accessors should be single-line or multi-line WIP: Enable SA1504: All accessors should be single-line or multi-line Nov 23, 2020
iSazonov
Ilya (iSazonov) reviewed Nov 24, 2020
View reviewed changes
Comment thread src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimAssociatedInstanceCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 27, 2020
@xtqqczze
Fix SA1504: All accessors should be single-line or multi-lin
2028d92 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
@xtqqczze
xtqqczze force-pushed the SA1504 branch from fe19a41 to 2028d92 Compare December 11, 2020 23:02
@xtqqczze xtqqczze changed the title WIP: Enable SA1504: All accessors should be single-line or multi-line Enable SA1504: All accessors should be single-line or multi-line Dec 11, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2020
@xtqqczze xtqqczze closed this Dec 12, 2020
@xtqqczze xtqqczze reopened this Dec 12, 2020
@xtqqczze xtqqczze closed this Dec 13, 2020
@xtqqczze xtqqczze reopened this Dec 13, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review December 13, 2020 12:35
@xtqqczze
xtqqczze requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 13, 2020 12:35
iSazonov
Ilya (iSazonov) approved these changes Dec 13, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020
@ghost

Deleted user (ghost) commented Dec 23, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov
Ilya (iSazonov) merged commit b7a431a into PowerShell:master Jan 9, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@xtqqczze
xtqqczze deleted the SA1504 branch January 18, 2021 08:17
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix SA1504: All accessors should be single-line or multi-lin (PowerSh…
88356b3 
…ell#14241)

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.