GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix RCS1188: Remove redundant auto-property initialization part 2 by xtqqczze · Pull Request #14262 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 25, 2020

Copy link
Copy Markdown
Contributor

src\Microsoft.PowerShell.Commands.Utility\Microsoft.PowerShell.Commands.Utility.csproj

Follow-up to #14244.

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1188.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Fix RCS1188: Remove redundant auto-property initialization part 2
8c501a6 
`src\Microsoft.PowerShell.Commands.Utility\Microsoft.PowerShell.Commands.Utility.csproj`

Follow-up to PowerShell#14244.

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1188.md
@xtqqczze
xtqqczze requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 25, 2020 12:16
@ghost ghost assigned Rob Holt (rjmholt) Nov 25, 2020
@xtqqczze

xtqqczze commented Nov 25, 2020

Copy link
Copy Markdown
Contributor Author

restarting tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Nov 25, 2020
@xtqqczze xtqqczze reopened this Nov 25, 2020
iSazonov
Ilya (iSazonov) reviewed Nov 26, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/PingPathCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
xtqqczze
xtqqczze commented Nov 26, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/NewTimeSpanCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 3, 2020
rjmholt
Rob Holt (rjmholt) reviewed Dec 3, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Rob Holt (rjmholt) requested a review from Steve Lee (SteveL-MSFT) December 3, 2020 17:56
@xtqqczze
revert changes to enums
7075090 
address @iSazonov review
@xtqqczze
xtqqczze force-pushed the RCS1188-p2 branch from ff282c1 to 7075090 Compare December 3, 2020 19:31
@xtqqczze

xtqqczze commented Dec 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author 
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/dev-process/coding-guidelines.md.https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments should work
Failed to complete request to "https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments". Response status code does not indicate success: 404 (Not Found).

Issue opened: #14313.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) reviewed Dec 4, 2020
View reviewed changes
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze
revert change
3641aaa 
address @iSazonov review
iSazonov
Ilya (iSazonov) approved these changes Dec 4, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 4, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Rob Holt (rjmholt) Dec 4, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 4, 2020
@iSazonov
Ilya (iSazonov) merged commit 75b5813 into PowerShell:master Dec 4, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 4, 2020
@xtqqczze
xtqqczze deleted the RCS1188-p2 branch December 4, 2020 11:56
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix RCS1188: Remove redundant auto-property initialization part 2 (Po…
f0db9fe 
…werShell#14262)

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1188.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @rjmholt @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.