GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix StyleCop and MarkdownLint CI failures by xtqqczze · Pull Request #14297 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 30, 2020 •
edited by rjmholt
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #14295. Also addresses StyleCop CI errors.

Combination of commits from #14293 and #14296, to check if tests pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
xtqqczze added 2 commits November 30, 2020 20:06
@xtqqczze
Update link to xunit docs
3edac9f
@xtqqczze
Upgrade StyleCopAnalyzers to v1.2.0-beta.261
599455c
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Nov 30, 2020
@rjmholt Rob Holt (rjmholt) assigned Rob Holt (rjmholt) and unassigned Aditya Patwardhan (adityapatwardhan) Nov 30, 2020
@rjmholt Rob Holt (rjmholt) changed the title WIP: Fix CI Fix StyleCop and MarkdownLint CI failures Nov 30, 2020
@rjmholt

Rob Holt (rjmholt) commented Nov 30, 2020

Copy link
Copy Markdown
Collaborator

I'm going to merge this PR and close the other two, since that will make managing the commit easier if we need to cherry-pick it
xtqqczze reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Rob Holt (rjmholt) marked this pull request as ready for review November 30, 2020 20:51
@rjmholt
Rob Holt (rjmholt) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners November 30, 2020 20:51
rjmholt
Rob Holt (rjmholt) approved these changes Nov 30, 2020
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 00c70f9 into PowerShell:master Nov 30, 2020
This was referenced Nov 30, 2020
Upgrade StyleCopAnalyzers to v1.2.0-beta.261 #14293
Closed
Update link to xunit docs #14296
Closed
Implement Cleanup { } Function Block #9900
Closed
@xtqqczze
xtqqczze deleted the fix-ci branch November 30, 2020 21:15
@xtqqczze xtqqczze mentioned this pull request Nov 30, 2020
Disable SA1000: Keywords should be spaced correctly #14292
Closed
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 1, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 1, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Dec 1, 2020
Avoid array allocations in CorePsAssemblyLoadContext #14291
Merged
8 tasks done
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost mentioned this pull request Dec 15, 2020
Test failure - https://xunit.github.io/ should work #14295
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix StyleCop and MarkdownLint CI failures (PowerShell#14297)
0e65a8b 
* Update link to xunit docs
* Upgrade StyleCopAnalyzers to v1.2.0-beta.261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Test failure - https://xunit.github.io/ should work

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@xtqqczze @rjmholt @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.