GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use StringComparison.Ordinal insted of StringComparison.CurrentCulture at startup time by iSazonov · Pull Request #14298 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Dec 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Use StringComparison.Ordinal instead of default StringComparison.CurrentCulture.

This looks like a bug but discovered in startup scenario perf analyze - perf win 0.7% (5 ms - so long because of ICU initialization).

PR Context

Related #14268

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iSazonov
Use StringComparison.Ordinal insted of StringComparison.CurrentCulture
e3c7e41
@iSazonov Ilya (iSazonov) added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 1, 2020
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) December 1, 2020 06:05
@iSazonov
Ilya (iSazonov) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 1, 2020 06:05
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Dec 1, 2020
@iSazonov Ilya (iSazonov) mentioned this pull request Dec 1, 2020
Startup performance PowerShell 7.2.0-Preview.1 #14268
Closed
12 of 15 tasks
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 2, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) closed this Dec 2, 2020
@iSazonov Ilya (iSazonov) reopened this Dec 2, 2020
@iSazonov

Ilya (iSazonov) commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator Author

Reopen to restart CIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) mentioned this pull request Dec 2, 2020
Use OrdinalIgnoreCase in CommandLineParser #14303
Merged
7 of 14 tasks
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 548e939 into PowerShell:master Dec 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 3, 2020
@iSazonov
Ilya (iSazonov) deleted the perf-startwith branch December 3, 2020 02:58
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Use StringComparison.Ordinal insted of `StringComparison.CurrentCul…
fe04177
…ture` (PowerShell#14298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.