GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update markdown test tools by RDIL · Pull Request #14325 · PowerShell/PowerShell

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Reece Dunham [email protected]

PR Summary

  • Update the external markdown testing tools to the latest version

PR Context

Staying somewhat up-to-date

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost assigned Andrew (anmenaga) Dec 4, 2020
@xtqqczze

xtqqczze commented Dec 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
2020-12-04T21:26:40.2433904Z       [-] https://github.com/powershell/powershell-rfc → Status: 429 should work 60.18s
2020-12-04T21:26:40.2467358Z         RuntimeException: Failed to complete request to "https://github.com/powershell/powershell-rfc → Status: 429". Response status code does not indicate success: 404 (Not Found).
2020-12-04T21:26:40.2469184Z         at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119

HTTP 429 -> Too many requests

Related upstream issue: tcort/markdown-link-check#101

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Related upstream issue: tcort/markdown-link-check#101

The issue is fixed in tcort/markdown-link-check#106 but there is not yet a markdown-link-check release with these changes (see tcort/markdown-link-check#141) Fixed in v3.8.4.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

It seems markdown-link-check is making a HTTP GET request for every URL. This is not ideal behaviour for large binaries, to say the least:

PowerShell/README.md

Lines 65 to 112 in ea3036d

[lts-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/PowerShell-7.0.3-win-x86.msi
[lts-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/PowerShell-7.0.3-win-x64.msi
[lts-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.ubuntu.18.04_amd64.deb
[lts-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.ubuntu.16.04_amd64.deb
[lts-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.debian.9_amd64.deb
[lts-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.debian.10_amd64.deb
[lts-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-1.rhel.7.x86_64.rpm
[lts-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-1.centos.8.x86_64.rpm
[lts-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-osx-x64.pkg
[rl-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x64.msi
[rl-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.msi
[rl-ubuntu20]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.20.04_amd64.deb
[rl-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.18.04_amd64.deb
[rl-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.16.04_amd64.deb
[rl-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.9_amd64.deb
[rl-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.10_amd64.deb
[rl-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.11_amd64.deb
[rl-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-1.rhel.7.x86_64.rpm
[rl-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-1.centos.8.x86_64.rpm
[rl-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-osx-x64.pkg
[rl-winarm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-arm64.zip
[rl-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.zip
[rl-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x64.zip
[rl-macos-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-osx-x64.tar.gz
[rl-linux-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-x64.tar.gz
[rl-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-arm32.tar.gz
[rl-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-arm64.tar.gz
[rl-snap]: https://snapcraft.io/powershell
[pv-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.msi
[pv-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.msi
[pv-ubuntu20]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.20.04_amd64.deb
[pv-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.18.04_amd64.deb
[pv-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.16.04_amd64.deb
[pv-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.9_amd64.deb
[pv-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.10_amd64.deb
[pv-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.11_amd64.deb
[pv-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview-7.2.0_preview.1-1.rhel.7.x86_64.rpm
[pv-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview-7.2.0_preview.1-1.centos.8.x86_64.rpm
[pv-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-osx-x64.pkg
[pv-winarm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-arm64.zip
[pv-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.zip
[pv-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.zip
[pv-macos-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-osx-x64.tar.gz
[pv-linux-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-x64.tar.gz
[pv-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm32.tar.gz
[pv-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm64.tar.gz

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

Reece Dunham (@RDIL) Please update markdown-link-check to v3.8.4.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

PowerShell-CI-static-analysis still has HTTP error 429 -> Too many requests

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

PowerShell-CI-static-analysis still has HTTP error 429 -> Too many requests

We need update markdown-link-check config or commandline with

retryOn429 if this is true then retry request when response is an HTTP code 429 after the duration indicated by retry-after header.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Documentation should be updated as well:

PowerShell/.github/CONTRIBUTING.md

Lines 91 to 102 in bb78d4b

#### Checking links in documentation
Documentation is link-checked. We make use of the
markdown-link-check command line tool,
which can be run to see if any links are dead.
To run the link-checker, follow these steps:
* install [Node.js](https://nodejs.org/en/) (v6.4.0 or up)
* install markdown-link-check by
`npm install -g [email protected]` (v3.7.2 **only**)
* run `find . \*.md -exec markdown-link-check {} \;`

RDIL reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL
Reece Dunham (RDIL) requested review from Travis Plunk (TravisEz13) and Joey Aiello (joeyaiello) as code owners December 9, 2020 17:10
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 9, 2020
@RDIL

Reece Dunham (RDIL) commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

PoshChan-Bot (@PoshChan) please rerun linux

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PoshChan

PoshChan-Bot (PoshChan) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

Reece Dunham (@RDIL), you are not authorized to request a rebuild

RDIL reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL

Reece Dunham (RDIL) commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Fine, I'll do it myself.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL Reece Dunham (RDIL) closed this Dec 9, 2020
@RDIL Reece Dunham (RDIL) reopened this Dec 9, 2020
iSazonov
Ilya (iSazonov) reviewed Dec 9, 2020
View reviewed changes
Comment thread docs/maintainers/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Dec 9, 2020
View reviewed changes
Comment thread docs/community/governance.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

xtqqczze
xtqqczze reviewed Dec 9, 2020
View reviewed changes
Comment thread test/common/markdown/markdown-link.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 9, 2020
View reviewed changes
@RDIL Reece Dunham (RDIL) closed this Dec 15, 2020
@RDIL Reece Dunham (RDIL) reopened this Dec 15, 2020
@RDIL Reece Dunham (RDIL) closed this Dec 15, 2020
@RDIL Reece Dunham (RDIL) reopened this Dec 15, 2020
@xtqqczze

xtqqczze commented Dec 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PowerShell-CI-static-analysis (Markdown and Common Tests):

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work

Connection timed out

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze

xtqqczze commented Dec 15, 2020 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PowerShell-CI-static-analysis (Markdown and Common Tests):

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work

Connection timed out

Look like a transient failure, but I've submitted #14431 to update the 301 redirect.

Computer Performance
Windows PowerShell Tutorial - Introduction Microsoft's new scripting language
Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL

Reece Dunham (RDIL) commented Dec 15, 2020 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-static-analysis (Markdown and Common Tests):
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work
Connection timed out

Look like a transient failure, but I've submitted #14431 to update the 301 redirect.

Computer Performance**Windows PowerShell Tutorial - Introduction Microsoft's new scripting language**Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.

I'll rebase once that gets merged.

Computer Performance
Windows PowerShell Tutorial - Introduction Microsoft's new scripting language
Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL Reece Dunham (RDIL) changed the title Update markdown test tools [On Hold] Update markdown test tools Dec 15, 2020
@xtqqczze

xtqqczze commented Dec 15, 2020

Copy link
Copy Markdown
Contributor

I'll rebase once that gets merged.

Reece Dunham (@RDIL) No need wait for that PR, failures in PowerShell-CI-static-analysis have not persisted.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020
@ghost

Deleted user (ghost) commented Dec 23, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RDIL Reece Dunham (RDIL) changed the title [On Hold] Update markdown test tools Update markdown test tools Dec 23, 2020
Reece Dunham (RDIL) added 5 commits December 24, 2020 16:27
@RDIL
Update markdown test tools
eb3deb9
Signed-off-by: Reece Dunham <[email protected]>
@RDIL
3.8.4
3a87aa5
@RDIL
Update docs, retry flag
f8d7d07
@RDIL
Fix actual dead links
d092102
Signed-off-by: Reece Dunham <[email protected]>
@RDIL
Experiment with removing 429 from allowed failures
1791131
@RDIL
Reece Dunham (RDIL) requested review from Steve Lee (SteveL-MSFT), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 24, 2020 16:27
@RDIL

Reece Dunham (RDIL) commented Dec 24, 2020

Copy link
Copy Markdown
Contributor Author

Whoops, that wasn't supposed to happen - sorry for anybody that got pinged due to my rebase, it usually doesn't do that!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reece Dunham (RDIL) added 2 commits December 24, 2020 12:05
@RDIL
Update links
973748b
@RDIL
Update links
e35aa83
@RDIL
Reece Dunham (RDIL) requested a review from Ilya (iSazonov) December 24, 2020 17:06
xtqqczze
xtqqczze approved these changes Dec 24, 2020
View reviewed changes
@RDIL
Merge branch 'master' into master
45bc72e
iSazonov
Ilya (iSazonov) approved these changes Jan 12, 2021
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 4a09585 into PowerShell:master Jan 12, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 12, 2021
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Andrew (anmenaga) Jan 12, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 12, 2021
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@RDIL
Update markdown test tools (PowerShell#14325)
2e2cfba
* Update markdown test tools

* Update docs, retry flag

* Fix actual dead links

* Update links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+1 more reviewer
@xtqqczze xtqqczze xtqqczze approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RDIL @xtqqczze @iSazonov @PoshChan @TravisEz13 @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.