GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace GetFiles in AnalysisCache by xtqqczze · Pull Request #14326 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

Contributes to #14318.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xtqqczze
Avoid array allocations from GetDirectories/GetFiles.
20e6b12 
Contributes to PowerShell#14318.
@ghost ghost assigned Dongbo Wang (daxian-dbw) Dec 5, 2020
@xtqqczze xtqqczze changed the title Avoid array allocations from GetDirectories/GetFiles. Replace GetFiles in AnalysisCache Dec 5, 2020
@xtqqczze xtqqczze closed this Dec 5, 2020
@xtqqczze xtqqczze reopened this Dec 5, 2020
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 12, 2020
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 12, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 19, 2020
@ghost

Deleted user (ghost) commented Dec 19, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Jan 10, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 10, 2021
@iSazonov
Ilya (iSazonov) merged commit 8315515 into PowerShell:master Jan 10, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 10, 2021
@xtqqczze
xtqqczze deleted the getfiles-AnalysisCache branch January 18, 2021 08:05
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Avoid array allocations from GetDirectories/GetFiles. (PowerShell#14326)
2b6771f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @daxian-dbw @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.