GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace `GetFiles` in `CompletionCompleters` by xtqqczze · Pull Request #14329 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 5, 2020

Copy link
Copy Markdown
Contributor

Contributes to #14318.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Travis Plunk (TravisEz13) Dec 5, 2020
@xtqqczze
Avoid array allocations from GetDirectories/GetFiles.
5911596 
Contributes to PowerShell#14318.
@xtqqczze
xtqqczze force-pushed the getfiles-ModuleUtils branch from 71da3b8 to 5911596 Compare December 5, 2020 12:19
@xtqqczze
Inline temporaries
9a183e6
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 12, 2020
@ghost

Deleted user (ghost) commented Dec 12, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze xtqqczze closed this Jun 24, 2021
@xtqqczze xtqqczze reopened this Jun 24, 2021
@xtqqczze xtqqczze closed this Jun 25, 2021
@xtqqczze xtqqczze reopened this Jun 25, 2021
@xtqqczze xtqqczze closed this Jun 27, 2021
@xtqqczze xtqqczze reopened this Jun 27, 2021
iSazonov
Ilya (iSazonov) approved these changes Jun 28, 2021
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 28, 2021
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 5, 2021
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@ghost ghost removed this from the 7.2.0-preview.9 milestone Aug 5, 2021
@ghost

Deleted user (ghost) commented Aug 5, 2021

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) changed the title Replace GetFiles in CompletionCompleters Replace GetFiles in CompletionCompleters Aug 5, 2021
@TravisEz13
Travis Plunk (TravisEz13) merged commit 58483e1 into PowerShell:master Aug 5, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@xtqqczze
xtqqczze deleted the getfiles-ModuleUtils branch August 6, 2021 02:36
@ghost

Deleted user (ghost) commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Replace GetFiles in CompletionCompleters (PowerShell#14329)
79955e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.9

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.