GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix IDE0090: Simplify new expression part 7 by xtqqczze · Pull Request #14341 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Andrew (anmenaga) Dec 7, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review December 7, 2020 15:23
@xtqqczze
xtqqczze force-pushed the IDE0090-p7 branch from 8e4e150 to 3d26f73 Compare December 7, 2020 15:24
iSazonov
Ilya (iSazonov) reviewed Dec 9, 2020
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xtqqczze I stopped review - too many unrelated changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Security/security/AclCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Dec 9, 2020
@xtqqczze
Remove useless assignment to locals
ba6abe6 
Follow-up to PowerShell#14341.
@xtqqczze xtqqczze mentioned this pull request Dec 9, 2020
Remove redundant local assignment in AclCommands #14358
Merged
@xtqqczze
xtqqczze marked this pull request as draft December 9, 2020 17:05
xtqqczze added 2 commits December 12, 2020 20:43
@xtqqczze
Fix IDE0090: Simplify new expression part 7
44e84fb 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090
@xtqqczze
Reformat
f023521
@xtqqczze
xtqqczze force-pushed the IDE0090-p7 branch from 3d26f73 to f023521 Compare December 12, 2020 21:49
@xtqqczze
xtqqczze marked this pull request as ready for review December 12, 2020 21:50
iSazonov
Ilya (iSazonov) approved these changes Dec 13, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 20, 2020
@ghost

Deleted user (ghost) commented Dec 20, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Andrew (anmenaga) Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov
Ilya (iSazonov) merged commit 3c7f4b5 into PowerShell:master Jan 9, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@xtqqczze xtqqczze mentioned this pull request Jun 21, 2021
Fix IDE0090: Simplify new expression #15627
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix IDE0090: Simplify new expression part 7 (PowerShell#14341)
03f58e9 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.