GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue with unsigned build by TravisEz13 · Pull Request #14367 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Dec 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Fix issue with unsigned build

Also

  • Fix issue when master is manually triggered (setReleaseTag.ps1)

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Travis Plunk (TravisEz13) added 5 commits December 9, 2020 12:55
@TravisEz13
fix issue with manually building master
0e5adc0
@TravisEz13
only scan when signed
27b2102
@TravisEz13
pass through shouldsign
3f5acf4
@TravisEz13
REVERT ME: switch to should sign branch
0397a73
@TravisEz13
Revert "REVERT ME: switch to should sign branch"
5763114
This reverts commit 0397a73.
@ghost ghost assigned Dongbo Wang (daxian-dbw) Dec 9, 2020
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Consider labels Dec 9, 2020
@rjmholt
Rob Holt (rjmholt) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) December 9, 2020 22:32
JamesWTruher
James Truher (JamesWTruher) approved these changes Dec 9, 2020
View reviewed changes
rjmholt
Rob Holt (rjmholt) approved these changes Dec 9, 2020
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review December 9, 2020 22:49
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners December 9, 2020 22:49
@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 9, 2020
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.2 milestone Dec 9, 2020
@ghost ghost removed this from the 7.2.0-preview.2 milestone Dec 9, 2020
@ghost

Deleted user (ghost) commented Dec 9, 2020

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13
Travis Plunk (TravisEz13) merged commit f6fa262 into PowerShell:master Dec 9, 2020
@TravisEz13
Travis Plunk (TravisEz13) deleted the fix-daily-build branch December 9, 2020 22:51
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 9, 2020

Copy link
Copy Markdown
Member Author

merged early to make sure tomorrow's build tests the changes

rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.2 milestone Dec 9, 2020
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Approved and removed BackPort-7.0.x-Consider labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13
Fix issue with unsigned build (#14367)
02aa91e
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.1.x-Done Backport to 7.1.x completed and removed BackPort-7.1.x-Approved labels Dec 16, 2020
Travis Plunk (TravisEz13) added a commit that referenced this pull request Dec 16, 2020
@TravisEz13
Fix issue with unsigned build (#14367)
02bbf0f
@TravisEz13 Travis Plunk (TravisEz13) added Backport-7.0.x-Done and removed BackPort-7.0.x-Approved labels Dec 17, 2020
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShell that referenced this pull request Jan 12, 2021
@TravisEz13
Fix issue with unsigned build (PowerShell#14367)
d007591
@ghost

Deleted user (ghost) commented Jan 14, 2021

Copy link
Copy Markdown

🎉v7.1.1 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Jan 19, 2021

Copy link
Copy Markdown

🎉v7.0.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Oct 12, 2022
Back-port to 7.0: Update list of PowerShell team members in release tools #18266
Merged
22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Fix issue with unsigned build (PowerShell#14367)
b194475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

Backport-7.0.x-Done Backport-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @rjmholt @JamesWTruher @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.