GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable CA2249: Consider using String.Contains instead of IndexOf by xtqqczze · Pull Request #14395 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits December 11, 2020 00:40
@xtqqczze
Enable CA2249: Consider using String.Contains instead of IndexOf
ba6abee 
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249
@xtqqczze
Restore StringComparison.Ordinal
d4ac21d 
Fix CA1307
@ghost ghost assigned Travis Plunk (TravisEz13) Dec 11, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review December 11, 2020 16:07
@xtqqczze
xtqqczze requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) as code owners December 11, 2020 16:07
iSazonov
Ilya (iSazonov) reviewed Dec 12, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ImplicitRemotingCommands.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/cimSupport/cmdletization/ScriptWriter.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 12, 2020
xtqqczze added 2 commits December 13, 2020 11:25
@xtqqczze
Reformat
2c71537
@xtqqczze
Remove unecessary namespace
cec1b45
iSazonov
Ilya (iSazonov) approved these changes Dec 13, 2020
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 21, 2020
@ghost

Deleted user (ghost) commented Dec 21, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Jan 10, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 10, 2021
@iSazonov
Ilya (iSazonov) merged commit 9ea718f into PowerShell:master Jan 10, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 10, 2021
@xtqqczze
xtqqczze deleted the CA2249 branch January 18, 2021 03:00
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable CA2249: Consider using String.Contains instead of IndexOf (Po…
5599988 
…werShell#14395)

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.