GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — Add `isOutputRedirected` parameter to `GetFormatStyleString()` method by SteveL-MSFT · Pull Request #14397 · PowerShell/PowerShell Conversation
|
|
Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b5a6f30 to
9fb8e62
Compare
|
The PR should close #14387 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
9fb8e62 to
e5c4a60
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Steve Lee (@SteveL-MSFT) Sorry that I lost track of this PR. The changes look good to me, but it doesn't address all the issues tracked in #14387.
I think we need to make GetOutputString and GetFormatStyleString public, so that other host implementation can behave just like the console host. Otherwise, other hosts will have to copy the source code of those 2 methods. What do you think?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The markdown test failed due to a broken link, which has nothing to do with this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… instead of checking within the method
e5c4a60 to
62941e4
Compare
|
Dongbo Wang (@daxian-dbw) I think we can defer making those APIs public util we have a host that needs it |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Steve Lee (@SteveL-MSFT) The host of PowerShell Jupyter kernel will need them. Once .NET interactive adopts PowerShell 7.2, it will be a matter of time for users to open the issue about And, maybe the PSES host will need them too? Rob Holt (@rjmholt) can you please weigh in. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.