GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable SA1205: Partial elements should declare access by xtqqczze · Pull Request #14441 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1205.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost ghost assigned Travis Plunk (TravisEz13) Dec 16, 2020
iSazonov
Ilya (iSazonov) approved these changes Dec 17, 2020
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase to pass CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 17, 2020
@xtqqczze
Enable SA1205: Partial elements should declare access
3ba166c 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1205.md
@xtqqczze
xtqqczze force-pushed the SA1205 branch from f88fbf8 to 3ba166c Compare December 19, 2020 17:53
@iSazonov Ilya (iSazonov) closed this Dec 19, 2020
@iSazonov Ilya (iSazonov) reopened this Dec 19, 2020
@iSazonov

Ilya (iSazonov) commented Dec 19, 2020

Copy link
Copy Markdown
Collaborator

Reopen to update CLA status.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xtqqczze

xtqqczze commented Dec 23, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you please merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Travis Plunk (TravisEz13) Dec 24, 2020
@iSazonov
Ilya (iSazonov) merged commit 281b437 into PowerShell:master Dec 24, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Dec 24, 2020
@xtqqczze
xtqqczze deleted the SA1205 branch December 24, 2020 04:19
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Enable SA1205: Partial elements should declare access (PowerShell#14441)
54c2602 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1205.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.