GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support to `$PSStyle` for strikethrough and hyperlinks by SteveL-MSFT · Pull Request #14461 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Dec 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Strikethrough was missed in the initial implementation. Hyperlinks are getting more broadly supported so that should be added.

Also added missing tests for FromRGB() method.

PR Context

Fix #14459
Fix #14460

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SteveL-MSFT
Add support to $PSStyle for strikethrough and hyperlinks
f128324
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Ilya (iSazonov) December 18, 2020 19:28
@ghost ghost assigned Dongbo Wang (daxian-dbw) Dec 18, 2020
TylerLeonhardt
TylerLeonhardt reviewed Dec 18, 2020
View reviewed changes
Comment thread src/System.Management.Automation/FormatAndOutput/common/PSStyle.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) added 2 commits December 18, 2020 12:17
@SteveL-MSFT
update formatting for new property and change to FormatHyperlink()
6272e98
@SteveL-MSFT
fix codefactor issue
b2a3b44
TylerLeonhardt
TylerLeonhardt approved these changes Dec 18, 2020
View reviewed changes
@SteveL-MSFT
fix cut and paste error with formatting
518c735
iSazonov
Ilya (iSazonov) approved these changes Dec 19, 2020
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 19, 2020
@iSazonov
Ilya (iSazonov) merged commit bc08092 into PowerShell:master Dec 19, 2020
@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Dongbo Wang (daxian-dbw) Dec 19, 2020
@iSazonov Ilya (iSazonov) added this to the 7.3-Consider milestone Dec 19, 2020
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the strikethrough-links branch December 19, 2020 15:16
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Feb 12, 2021
Support ANSI links in $PSStyle #14460
Closed
Have a $PSStyle.Strikethrough #14459
Closed
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Feb 18, 2021
Add support to $PSStyle for strikethrough and hyperlinks MicrosoftDocs/PowerShell-Docs#7265
Closed
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request May 13, 2022
Add Strikethrough to $PSStyle docs MicrosoftDocs/PowerShell-Docs#8810
Closed
3 tasks done
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT
Add support to $PSStyle for strikethrough and hyperlinks (PowerShel…
8bbce0c
…l#14461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.3-Consider

Development

Successfully merging this pull request may close these issues.

Support ANSI links in $PSStyle Have a $PSStyle.Strikethrough

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SteveL-MSFT @TylerLeonhardt @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.