GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #4750 Fix Get-Date -UFormat %u behavior by brianary · Pull Request #14549 · PowerShell/PowerShell

Conversation

@brianary

@brianary Brian Lalonde (brianary) commented Jan 5, 2021 •
edited by iSazonov
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Corrects the behavior of %u in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed: Document Request: Get-Date -UFormat %u ISO8601 standard (1-7) MicrosoftDocs/PowerShell-Docs#7180
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost assigned Rob Holt (rjmholt) Jan 5, 2021
@ghost

Deleted user (ghost) commented Jan 5, 2021 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brianary

Brian Lalonde (brianary) commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

I can't really access the details, but the test failures appear to be unrelated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Jan 6, 2021
iSazonov
Ilya (iSazonov) reviewed Jan 6, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1 Outdated
Comment on lines 100 to 105

@iSazonov Ilya (iSazonov) Jan 6, 2021

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify how you select the test values (whole list)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@brianary Brian Lalonde (brianary) Jan 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used the values from the previous test for %V, which is related, then added a couple recent dates that had led to discovering the bug. I'll add a comment to that effect, or else select some other dates.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iSazonov Ilya (iSazonov) mentioned this pull request Jan 6, 2021
Get-Date -UFormat inconsistencies compared to Linux strftime #4750
Closed
8 of 14 tasks
iSazonov
Ilya (iSazonov) approved these changes Jan 6, 2021
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 14, 2021
@ghost

Deleted user (ghost) commented Jan 14, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brianary

Brian Lalonde (brianary) commented Jan 15, 2021

Copy link
Copy Markdown
Contributor Author

Let me know if there's anything further I can provide.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jan 15, 2021
@iSazonov

Ilya (iSazonov) commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Since it is a breaking change I ask PowerShell Committee to approve.

brianary reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 15, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 20, 2021
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 20, 2021

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee reviewed this, we agreed that this is a bug that should be fixed and this is likely a bucket 3 compatibility issue.

brianary and iSazonov reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brianary

Brian Lalonde (brianary) commented Jan 24, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) should #14555 also be taken with this one, since they are so tightly related?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Please create new issue in PowerShell-Doc repository and add a reference to the issue in the PR description.

brianary reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brianary Brian Lalonde (brianary) mentioned this pull request Jan 26, 2021
Document Request: Get-Date -UFormat %u ISO8601 standard (1-7) MicrosoftDocs/PowerShell-Docs#7180
Closed
@ghost

Deleted user (ghost) commented Feb 2, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Feb 2, 2021
rjmholt
Rob Holt (rjmholt) approved these changes Feb 2, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Please rebase. I hope after that CI-Windows will pass.

brianary reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 3, 2021
Brian Lalonde (BrianL-STCU) added 3 commits February 3, 2021 09:16
@BrianL-STCU
#4750 Fix Get-Date -UFormat %u behavior
6594b78
@BrianL-STCU
Changes from PR feedback
9e0bd61
@BrianL-STCU
Readability change as discussed in PR
ebea063
@brianary @rjmholt @BrianL-STCU
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get…
c7df635
…DateCommand.cs

Co-authored-by: Robert Holt <[email protected]>
@iSazonov Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Feb 4, 2021
@iSazonov
Ilya (iSazonov) merged commit 61fea6c into PowerShell:master Feb 4, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Feb 4, 2021
@iSazonov

Ilya (iSazonov) commented Feb 4, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Thanks for your contribution!

brianary reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@brianary
PowerShell#4750 Fix Get-Date -UFormat %u behavior (PowerShell#14549)
8d24101
Corrects a behavior of %u in Get-Date -UFormat to match ISO 8601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@brianary @iSazonov @SteveL-MSFT @rjmholt @BrianL-STCU
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.