GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — Native invocation using `ArgumentList` by JamesWTruher · Pull Request #14692 · PowerShell/PowerShell Conversation
|
|
/cc Michael Klement (@mklement0) Please look the PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
For the variable, I prefer |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Not sure if it's just a typo, but to be clear: this isn't about argument parsing, it's about argument passing (which, on Windows only, also involves encoding, as a single string - which
I can see why you would want to avoid the word "fix" in the variable name - even though that's what it comes down to. Again, what matters to the user is only the following - not technical characterizations based on plumbing users may not even know of:
Thus, if you do want an
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
7f6581d to
dcb79f5
Compare
|
@PowerShell/powershell-committee reviewed this, we agreed on automatic variable |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
dcb79f5 to
0985d70
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
eb105bd to
337877e
Compare
There was an error while loading. Please reload this page.
da24160 to
e4f7558
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Michael Klement (@mklement0) Do you want to review the PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…Binder.cs Co-authored-by: Ilya <[email protected]>
…Binder.cs Co-authored-by: Ilya <[email protected]>
|
PoshChan-Bot (@PoshChan) Please remind me in 1 hour |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Travis Plunk (@TravisEz13), this is the reminder you requested 1 hour ago |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Since this PR introduces a breaking change anyway and is being implemented as an experimental feature, I would like to understand why don't we implement mklement0's proposal in full as an experimental feature and close the long history?
Also I asked previously and still wonder why Michael Klement (@mklement0) is not in a PowerShell Committee. I believe MSFT team would have saved a lot of time and effort in this case. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ilya (@iSazonov) can you open a new issue w.r.t. #14692 (comment) and mark it for committee review? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
PoshChan-Bot (@PoshChan) Please remind me in 1 Hour |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The (hopefully) final proposal is now in #14747 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Travis Plunk (@TravisEz13), this is the reminder you requested 1 Hour ago |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
ArgumentList
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
[7.2.0-preview.5] - 2021-04-14 * Breaking Changes - Make PowerShell Linux deb and RPM packages universal (#15109) - Enforce AppLocker Deny configuration before Execution Policy Bypass configuration (#15035) - Disallow mixed dash and slash in command line parameter prefix (#15142) (Thanks @davidBar-On!) * Experimental Features - `PSNativeCommandArgumentPassing`: Use `ArgumentList` for native executable invocation (breaking change) (#14692) * Engine Updates and Fixes - Add `IArgumentCompleterFactory` for parameterized `ArgumentCompleters` (#12605) (Thanks @powercode!) * General Cmdlet Updates and Fixes - Fix SSH remoting connection never finishing with misconfigured endpoint (#15175) - Respect `TERM` and `NO_COLOR` environment variables for `$PSStyle` rendering (#14969) - Use `ProgressView.Classic` when Virtual Terminal is not supported (#15048) - Fix `Get-Counter` issue with `-Computer` parameter (#15166) (Thanks @krishnayalavarthi!) - Fix redundant iteration while splitting lines (#14851) (Thanks @hez2010!) - Enhance `Remove-Item -Recurse` to work with OneDrive (#14902) (Thanks @iSazonov!) - Change minimum depth to 0 for `ConvertTo-Json` (#14830) (Thanks @kvprasoon!) - Allow `Set-Clipboard` to accept empty string (#14579) - Turn on and off `DECCKM` to modify keyboard mode for Unix native commands to work correctly (#14943) - Fall back to `CopyAndDelete()` when `MoveTo()` fails due to an `IOException` (#15077) * Code Cleanup <details> <summary> <p>We thank the following contributors!</p> <p>@xtqqczze, @iSazonov, @ZhiZe-ZG</p> </summary> <ul> <li>Update .NET to <code>6.0.0-preview.3</code> (#15221)</li> <li>Add space before comma to hosting test to fix error reported by <code>SA1001</code> (#15224)</li> <li>Add <code>SecureStringHelper.FromPlainTextString</code> helper method for efficient secure string creation (#14124) (Thanks @xtqqczze!)</li> <li>Use static lambda keyword (#15154) (Thanks @iSazonov!)</li> <li>Remove unnecessary <code>Array</code> -> <code>List</code> -> <code>Array</code> conversion in <code>ProcessBaseCommand.AllProcesses</code> (#15052) (Thanks @xtqqczze!)</li> <li>Standardize grammar comments in Parser.cs (#15114) (Thanks @ZhiZe-ZG!)</li> <li>Enable <code>SA1001</code>: Commas should be spaced correctly (#14171) (Thanks @xtqqczze!)</li> <li>Refactor <code>MultipleServiceCommandBase.AllServices</code> (#15053) (Thanks @xtqqczze!)</li> </ul> </details> * Tools - Use Unix line endings for shell scripts (#15180) (Thanks @xtqqczze!) * Tests - Add the missing tag in Host Utilities tests (#14983) - Update `copy-props` version in `package.json` (#15124) * Build and Packaging Improvements <details> <summary> <p>We thank the following contributors!</p> <p>@JustinGrote</p> </summary> <ul> <li>Fix <code>yarn-lock</code> for <code>copy-props</code> (#15225)</li> <li>Make package validation regex accept universal Linux packages (#15226)</li> <li>Bump NJsonSchema from 10.4.0 to 10.4.1 (#15190)</li> <li>Make MSI and EXE signing always copy to fix daily build (#15191)</li> <li>Sign internals of EXE package so that it works correctly when signed (#15132)</li> <li>Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 (#15141)</li> <li>Update daily release tag format to work with new Microsoft Update work (#15164)</li> <li>Feature: Add Ubuntu 20.04 Support to install-powershell.sh (#15095) (Thanks @JustinGrote!)</li> <li>Treat rebuild branches like release branches (#15099)</li> <li>Update WiX to 3.11.2 (#15097)</li> <li>Bump NJsonSchema from 10.3.11 to 10.4.0 (#15092)</li> <li>Allow patching of preview releases (#15074)</li> <li>Bump Newtonsoft.Json from 12.0.3 to 13.0.1 (#15084, #15085)</li> <li>Update the <code>minSize</code> build package filter to be explicit (#15055)</li> <li>Bump NJsonSchema from 10.3.10 to 10.3.11 (#14965)</li> </ul> </details> * Documentation and Help Content - Merge `7.2.0-preview.4` changes to master (#15056) - Update `README` and `metadata.json` (#15046) - Fix broken links for `dotnet` CLI (#14937) [7.2.0-preview.5]: v7.2.0-preview.4...v7.2.0-preview.5
Co-authored-by: Ilya <[email protected]>
[7.2.0-preview.5] - 2021-04-14 * Breaking Changes - Make PowerShell Linux deb and RPM packages universal (PowerShell#15109) - Enforce AppLocker Deny configuration before Execution Policy Bypass configuration (PowerShell#15035) - Disallow mixed dash and slash in command line parameter prefix (PowerShell#15142) (Thanks @davidBar-On!) * Experimental Features - `PSNativeCommandArgumentPassing`: Use `ArgumentList` for native executable invocation (breaking change) (PowerShell#14692) * Engine Updates and Fixes - Add `IArgumentCompleterFactory` for parameterized `ArgumentCompleters` (PowerShell#12605) (Thanks @powercode!) * General Cmdlet Updates and Fixes - Fix SSH remoting connection never finishing with misconfigured endpoint (PowerShell#15175) - Respect `TERM` and `NO_COLOR` environment variables for `$PSStyle` rendering (PowerShell#14969) - Use `ProgressView.Classic` when Virtual Terminal is not supported (PowerShell#15048) - Fix `Get-Counter` issue with `-Computer` parameter (PowerShell#15166) (Thanks @krishnayalavarthi!) - Fix redundant iteration while splitting lines (PowerShell#14851) (Thanks @hez2010!) - Enhance `Remove-Item -Recurse` to work with OneDrive (PowerShell#14902) (Thanks @iSazonov!) - Change minimum depth to 0 for `ConvertTo-Json` (PowerShell#14830) (Thanks @kvprasoon!) - Allow `Set-Clipboard` to accept empty string (PowerShell#14579) - Turn on and off `DECCKM` to modify keyboard mode for Unix native commands to work correctly (PowerShell#14943) - Fall back to `CopyAndDelete()` when `MoveTo()` fails due to an `IOException` (PowerShell#15077) * Code Cleanup <details> <summary> <p>We thank the following contributors!</p> <p>@xtqqczze, @iSazonov, @ZhiZe-ZG</p> </summary> <ul> <li>Update .NET to <code>6.0.0-preview.3</code> (PowerShell#15221)</li> <li>Add space before comma to hosting test to fix error reported by <code>SA1001</code> (PowerShell#15224)</li> <li>Add <code>SecureStringHelper.FromPlainTextString</code> helper method for efficient secure string creation (PowerShell#14124) (Thanks @xtqqczze!)</li> <li>Use static lambda keyword (PowerShell#15154) (Thanks @iSazonov!)</li> <li>Remove unnecessary <code>Array</code> -> <code>List</code> -> <code>Array</code> conversion in <code>ProcessBaseCommand.AllProcesses</code> (PowerShell#15052) (Thanks @xtqqczze!)</li> <li>Standardize grammar comments in Parser.cs (PowerShell#15114) (Thanks @ZhiZe-ZG!)</li> <li>Enable <code>SA1001</code>: Commas should be spaced correctly (PowerShell#14171) (Thanks @xtqqczze!)</li> <li>Refactor <code>MultipleServiceCommandBase.AllServices</code> (PowerShell#15053) (Thanks @xtqqczze!)</li> </ul> </details> * Tools - Use Unix line endings for shell scripts (PowerShell#15180) (Thanks @xtqqczze!) * Tests - Add the missing tag in Host Utilities tests (PowerShell#14983) - Update `copy-props` version in `package.json` (PowerShell#15124) * Build and Packaging Improvements <details> <summary> <p>We thank the following contributors!</p> <p>@JustinGrote</p> </summary> <ul> <li>Fix <code>yarn-lock</code> for <code>copy-props</code> (PowerShell#15225)</li> <li>Make package validation regex accept universal Linux packages (PowerShell#15226)</li> <li>Bump NJsonSchema from 10.4.0 to 10.4.1 (PowerShell#15190)</li> <li>Make MSI and EXE signing always copy to fix daily build (PowerShell#15191)</li> <li>Sign internals of EXE package so that it works correctly when signed (PowerShell#15132)</li> <li>Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 (PowerShell#15141)</li> <li>Update daily release tag format to work with new Microsoft Update work (PowerShell#15164)</li> <li>Feature: Add Ubuntu 20.04 Support to install-powershell.sh (PowerShell#15095) (Thanks @JustinGrote!)</li> <li>Treat rebuild branches like release branches (PowerShell#15099)</li> <li>Update WiX to 3.11.2 (PowerShell#15097)</li> <li>Bump NJsonSchema from 10.3.11 to 10.4.0 (PowerShell#15092)</li> <li>Allow patching of preview releases (PowerShell#15074)</li> <li>Bump Newtonsoft.Json from 12.0.3 to 13.0.1 (PowerShell#15084, PowerShell#15085)</li> <li>Update the <code>minSize</code> build package filter to be explicit (PowerShell#15055)</li> <li>Bump NJsonSchema from 10.3.10 to 10.3.11 (PowerShell#14965)</li> </ul> </details> * Documentation and Help Content - Merge `7.2.0-preview.4` changes to master (PowerShell#15056) - Update `README` and `metadata.json` (PowerShell#15046) - Fix broken links for `dotnet` CLI (PowerShell#14937) [7.2.0-preview.5]: PowerShell/PowerShell@v7.2.0-preview.4...v7.2.0-preview.5
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.