GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update script to use .NET 6 build resources by adityapatwardhan · Pull Request #14705 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Feb 4, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

  • Update the script to use the .NET 6 resources fir building powershell.
  • Also consider updated packages on NuGet.org when checking for updates.
  • Remove references to .NET 5.
  • Add internalfeed url to metadata file

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
Update script to use .NET 6 build resources
ccaa967
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Dongbo Wang (daxian-dbw) February 4, 2021 19:39
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13) and Andrew (anmenaga) as code owners February 4, 2021 19:39
@ghost ghost assigned Rob Holt (rjmholt) Feb 4, 2021
anmenaga
Andrew (anmenaga) approved these changes Feb 4, 2021
View reviewed changes
rjmholt
Rob Holt (rjmholt) reviewed Feb 4, 2021
View reviewed changes
Comment thread DotnetRuntimeMetadata.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 4, 2021
View reviewed changes
Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/UpdateDotnetRuntime.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Aditya Patwardhan (adityapatwardhan) and others added 6 commits February 4, 2021 16:31
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
382c4c8
Co-authored-by: Dongbo Wang <[email protected]>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
ee6cee9
Co-authored-by: Dongbo Wang <[email protected]>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
c9acca4
Co-authored-by: Dongbo Wang <[email protected]>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
61fc986
Co-authored-by: Dongbo Wang <[email protected]>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
c5afcaf
Co-authored-by: Dongbo Wang <[email protected]>
@adityapatwardhan
Address feedback
d5b3cd1
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Feb 5, 2021

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) Rob Holt (@rjmholt) Please re-review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rjmholt
Rob Holt (rjmholt) approved these changes Feb 5, 2021
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 5, 2021
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit fdc9a91 into PowerShell:master Feb 5, 2021
@rjmholt
Rob Holt (rjmholt) deleted the updateDontet6 branch February 5, 2021 18:29
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 6, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Feb 6, 2021
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Update script to use .NET 6 build resources (PowerShell#14705)
7da2ff4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@adityapatwardhan @daxian-dbw @rjmholt @anmenaga @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.