GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Suppress Write-Progress in ConsoleHost if output is redirected and fix tests by SteveL-MSFT · Pull Request #14716 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Feb 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

When output is redirected, Write-Progress rendering of the ConsoleHost tries to hide the cursor (or show the cursor) which throws an exception. Fix is to not render any progress at all if output is redirected as it's likely used for automation anyways.

The Disconnect test seems to be failing where it validates the session is in a Disconnected state, but typically has been in a Disconnecting state. Updated test to handle both Disconnected and Disconnecting to allow it to pass.

Markdown URL link tests sometimes fail when the 3rd party site timesout. Added a status code to see what is being returned and whether we should allow that to pass.

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SteveL-MSFT
Adjust timing of Disconnect test
ba1d37b
@ghost ghost assigned Andrew (anmenaga) Feb 5, 2021
Steve Lee (SteveL-MSFT) added 2 commits February 5, 2021 11:50
@SteveL-MSFT
add more details of log for WinCompat test
ed80ee3
@SteveL-MSFT
Change disconnect test to handle Disconnecting case
83f2dc2
add more tracing to wincompat test
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Adjust timing of Disconnect test Fix robustness of Disconnect and WinCompat tests Feb 5, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Feb 5, 2021
Allow Set-Clipboard to accept empty string #14579
Merged
8 of 14 tasks
@SteveL-MSFT
wrap setting cursor visibility in try-catch as it fails in CI
609268c
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 5, 2021 21:11
@SteveL-MSFT
add try...catch for showing cursor
12a4d09
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 5, 2021
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
add status code to error message
41c0acf
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 6, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/ProgressPane.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT
suppress write-progress in consolehost if output is redirected
64c9c37
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Fix robustness of Disconnect and WinCompat tests Suppress Write-Progress in ConsoleHost if output is redirected and fix tests Feb 6, 2021
@daxian-dbw
Refactor WriteProgress method body a little bit
4c01dcc
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 8, 2021
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 6d7fbed into PowerShell:master Feb 8, 2021
@anmenaga Andrew (anmenaga) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 8, 2021
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the disconnect-test branch February 9, 2021 22:09
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT
Suppress Write-Progress in ConsoleHost if output is redirected an…
00f1c2e
…d fix tests (PowerShell#14716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @daxian-dbw @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.