GeezerVison is showing github.com — Suppress Write-Progress in ConsoleHost if output is redirected and fix tests by SteveL-MSFT · Pull Request #14716 · PowerShell/PowerShell
Conversation
PR Summary
When output is redirected, Write-Progress rendering of the ConsoleHost tries to hide the cursor (or show the cursor) which throws an exception. Fix is to not render any progress at all if output is redirected as it's likely used for automation anyways.
The Disconnect test seems to be failing where it validates the session is in a Disconnected state, but typically has been in a Disconnecting state. Updated test to handle both Disconnected and Disconnecting to allow it to pass.
Markdown URL link tests sometimes fail when the 3rd party site timesout. Added a status code to see what is being returned and whether we should allow that to pass.
PR Context
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
- Breaking changes
- User-facing changes
- Testing - New and feature
- Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
- Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
- Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
add more tracing to wincompat test
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Steve Lee (SteveL-MSFT)
changed the title
Fix robustness of Disconnect and WinCompat tests
Suppress Write-Progress in ConsoleHost if output is redirected and fix tests
Feb 6, 2021
|
🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:
Handy links:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Labels
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.