GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump .NET framework to 6.0.0-preview.1 by adityapatwardhan · Pull Request #14719 · PowerShell/PowerShell

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Feb 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Update the .NET framework to 6.0.0-preview.1

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested review from Travis Plunk (TravisEz13), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners February 5, 2021 20:10
@ghost ghost assigned Rob Holt (rjmholt) Feb 5, 2021
TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 5, 2021
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 5, 2021
View reviewed changes
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 5, 2021
View reviewed changes
Comment thread build.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Feb 5, 2021
View reviewed changes
Comment thread tools/packaging/packaging.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13
Travis Plunk (TravisEz13) approved these changes Feb 8, 2021
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the UpdatetoNet6 branch from fc54e6a to c850cdc Compare February 8, 2021 18:36
Aditya Patwardhan (adityapatwardhan) and others added 10 commits February 8, 2021 13:47
@adityapatwardhan
Bump .NET framework to 6.0.0-preview.1
d672ac4
@adityapatwardhan
Update to target framework net6.0
f348fbc
@adityapatwardhan
Replace deprecated APIs
1c6e425
@adityapatwardhan
Fix the wix file
4b3b8b7
@adityapatwardhan
Remove the usage of deprecated API and replace with appropriate API
f81be45
@daxian-dbw @adityapatwardhan
Remove old .NET SDKs
25490f7
@daxian-dbw @adityapatwardhan
Remove old SDKs in tests
d16cc76
@adityapatwardhan
Remove old SDK from windows packaging job
bb90e88
@adityapatwardhan
Use pwsh for windows-packaging job
f8d8f73
@adityapatwardhan
Remove --runtime from dotnet pack invocation
2cf631e
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) force-pushed the UpdatetoNet6 branch from e24d6be to 2cf631e Compare February 8, 2021 22:26
Dongbo Wang (daxian-dbw) and others added 4 commits February 8, 2021 15:06
@daxian-dbw
Revert unneeded changes and fix CodeFactor issue
fa67eac
@daxian-dbw
Make the old SDKs invisible to PowerShell
7475dd0
@adityapatwardhan
Add workaround for .NET SDK issue
bbce662
@adityapatwardhan
Merge branch 'UpdatetoNet6' of https://github.com/adityapatwardhan/Po…
168de59
…werShell into UpdatetoNet6
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Feb 9, 2021
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit b836de8 into PowerShell:master Feb 9, 2021
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the UpdatetoNet6 branch February 9, 2021 01:13
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 11, 2021
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 7.2.0-preview.3 milestone Feb 11, 2021
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anmenaga Andrew (anmenaga) mentioned this pull request Feb 17, 2021
Fix Bootstrap step in Windows daily test runs so that it finds .NET SDK 6 #14820
Merged
8 of 22 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Bump .NET framework to 6.0.0-preview.1 (PowerShell#14719)
b07be30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adityapatwardhan @daxian-dbw @TravisEz13 @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.