GeezerVison is showing github.com — Fix experimental feature list in powershell.config.json by anmenaga · Pull Request #14858 · PowerShell/PowerShell
Conversation
PR Summary
Experimental feature list is corrupted in powershell.config.json in some OS packages (e.g. PowerShell-7.2.0-preview.3-win-x64.zip and PowerShell-7.2.0-preview.3-win-x64.msi and nightly builds).
This results in all experimental features disabled by default (unless overridden by another-scoped config).
This PR fixes experimental feature list in powershell.config.json.
Problem screenshot:

PR Context
While fixing another issue, #14748 changed the type of collection with experimental features from System.Array to System.Collections.ArrayList.
The later used the ArrayList.Add(Object) method returns an index at which the value has been added, which ends up in the output stream, contaminating the expected output with experimental features.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
- Breaking changes
- User-facing changes
- Testing - New and feature
- Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
- Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).
- Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
- Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
- Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Andrew (anmenaga)
changed the title
Fix broken experimental feature list in powershell.config.json
Fix experimental feature list in powershell.config.json
Feb 19, 2021
|
🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:
Handy links:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Labels
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.