GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Build self-contained minimal size package for Guest Config team by daxian-dbw · Pull Request #14976 · PowerShell/PowerShell Conversation
|
|
Dongbo Wang (@daxian-dbw) - seems like there are some merge conflicts. please have a look. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Where does this get used?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. This was existing code, see below:
PowerShell/tools/releaseBuild/Images/microsoft_powershell_windowsservercore/PowerShellPackage.ps1
Lines 173 to 186 in 877c97f
| Write-Verbose "Exporting project.assets files ..." -Verbose | |
| $projectAssetsCounter = 1 | |
| $projectAssetsFolder = Join-Path -Path $destination -ChildPath 'projectAssets' | |
| $projectAssetsZip = Join-Path -Path $destination -ChildPath 'windowsProjectAssetssymbols.zip' | |
| Get-ChildItem $location\project.assets.json -Recurse | ForEach-Object { | |
| $subfolder = $_.FullName.Replace($location,'') | |
| $subfolder.Replace('project.assets.json','') | |
| $itemDestination = Join-Path -Path $projectAssetsFolder -ChildPath $subfolder | |
| New-Item -Path $itemDestination -ItemType Directory -Force | |
| $file = $_.FullName | |
| Write-Verbose "Copying $file to $itemDestination" -Verbose | |
| Copy-Item -Path $file -Destination "$itemDestination\" -Force | |
| $projectAssetsCounter++ |
Travis Plunk (@TravisEz13), shall we remove $projectAssetsCounter?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
d2b0cc2 to
7bb5ba2
Compare
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This should not change in this PR right?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The 21104.4 is not the official .NET 6 preview.1 SDK version. The nuget package versions are all correct, so this is the only place we need to change to make it use the official 6-preview.1 sdk.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Would this PR address this issue #5681 ? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ryan Yates (@kilasuit) This is considered to be one step toward that goal, but doesn't resolve that issue. This package is produced mainly for using PowerShell in a service, where startup perf is not a concern (thus no R2R/Crossgen) and GUI won't work (thus no WPF/WinForm). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Aditya Patwardhan (@adityapatwardhan) and Rob Holt (@rjmholt) Thanks for the review! I have addressed or replied to your comments, please take another look. Here is the new release build run: https://dev.azure.com/mscodehub/PowerShellCore/_build/results?buildId=175764&view=results |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
After that why do you build self-contained application? With shared framework you could significantly reduce a size of the packages. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
This is a requirement from the Azure Guest Configuration service. There is no shared framework available and the service depends on PS package to bring in the .NET runtime. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Aditya Patwardhan (@adityapatwardhan) please take another look; thank you. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🎉 Handy links: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.