GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Seal `ClientRemotePowerShell` by xtqqczze · Pull Request #15802 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Seal internal System.Management.Automation.Runspaces.Internal.ClientRemotePowerShell class as it not meant to be derived from.

The motivation of this PR is this comment by Paul Higinbotham (@PaulHigin) in #11820 (comment). Sealing the class enables fixing the disposable implementation as previously attempted in #11820.

Contributes to #15110.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ghost ghost assigned Ilya (iSazonov) Jul 20, 2021
@xtqqczze xtqqczze mentioned this pull request Jul 20, 2021
Unsealed IDisposable should contain protected virtual void Dispose(bool) method #11820
Closed
7 of 14 tasks
@xtqqczze
xtqqczze marked this pull request as ready for review July 20, 2021 12:55
@iSazonov

Ilya (iSazonov) commented Jul 21, 2021

Copy link
Copy Markdown
Collaborator

xtqqczze Please add more information in the PR description why we need this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 21, 2021
@xtqqczze

xtqqczze commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

xtqqczze Please add more information in the PR description why we need this.

done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov
Ilya (iSazonov) requested a review from Paul Higinbotham (PaulHigin) July 21, 2021 18:38
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Jul 27, 2021
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems wrong to have a Dispose function that doesn't do anything. Stream objects are closed through protocol messages and Dispose appears to be unneeded. However, this code is so old I hesitate to make any significant changes to it, for fear of regressions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@xtqqczze

xtqqczze commented Jul 28, 2021

Copy link
Copy Markdown
Contributor Author

Paul Higinbotham (@PaulHigin) Since we seal ClientRemotePowerShell, we can remove the disposable implementation completely.

We only instantiate the class in sealed class System.Management.Automation.ClientRemotePowerShell so there are only very few changes required for removal:
xtqqczze@de99b2431.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2021
@ghost

Deleted user (ghost) commented Aug 5, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Jan 19, 2022

Copy link
Copy Markdown
Collaborator

/rebase

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 19, 2022
xtqqczze added 4 commits January 19, 2022 06:33
@xtqqczze @iSazonov
Seal ClientRemotePowerShell
3127d09
Seal `System.Management.Automation.Runspaces.Internal.ClientRemotePowerShell`
@xtqqczze @iSazonov
Fix CS0628
e394992
Fix [CS0628: new protected member declared in sealed class](https://docs.microsoft.com/dotnet/csharp/misc/cs0628)
@xtqqczze @iSazonov
Fix IDE0044
3bcd1c8
Fix [IDE0044: Add readonly modifier](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044)
@xtqqczze @iSazonov
Simplify IDisposable implementation
b09d6aa
@github-actions
github-actions Bot force-pushed the seal-ClientRemotePowerShell branch from 633d09f to b09d6aa Compare January 19, 2022 06:34
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Jan 19, 2022
@iSazonov
Ilya (iSazonov) enabled auto-merge (squash) January 19, 2022 06:36
@iSazonov Ilya (iSazonov) closed this Jan 21, 2022
auto-merge was automatically disabled January 21, 2022 11:40

Pull request was closed

@iSazonov Ilya (iSazonov) reopened this Jan 21, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 21, 2022

Copy link
Copy Markdown

This PR has 46 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +21 -25
Percentile : 18.4%

Total files changed: 1

Change summary by file extension:
.cs : +21 -25

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov
Ilya (iSazonov) merged commit f83660e into PowerShell:master Jan 21, 2022
@xtqqczze

xtqqczze commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Thanks for merging :)

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze
xtqqczze deleted the seal-ClientRemotePowerShell branch February 1, 2022 14:08
@ghost

Deleted user (ghost) commented Feb 24, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@xtqqczze xtqqczze mentioned this pull request Dec 24, 2024
Remove SuppressFinalize from ClientRemoteSessionDSHandlerImpl #21218
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Seal ClientRemotePowerShell (PowerShell#15802)
e44e39d
Seal `System.Management.Automation.Runspaces.Internal.ClientRemotePowerShell

Simplify IDisposable implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @iSazonov @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.