GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix `CA1052` in `TypeCatalogGen` by xtqqczze · Pull Request #15840 · PowerShell/PowerShell

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 29, 2021

Copy link
Copy Markdown
Contributor
  • Fix CA1052: Static holder types should be Static or NotInheritable in Microsoft.PowerShell.CoreCLR.TypeCatalogGen
  • Enable TreatWarningsAsErrors for TypeCatalogGen.csproj

In #15775, we missed a warning as TreatWarningsAsErrors was not enabled.

Again, possible breaking public API change (Unlikely Grey Area), however instantiating the class has no obvious utility and furthermore the API doesn't appear to be publicly documented.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xtqqczze added 2 commits July 29, 2021 02:38
@xtqqczze
Fix CA1052
9cd15ce
@xtqqczze
Enable TreatWarningsAsErrors
eb73b2e
@xtqqczze
xtqqczze requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners July 29, 2021 01:55
@ghost ghost assigned Travis Plunk (TravisEz13) Jul 29, 2021
iSazonov
Ilya (iSazonov) approved these changes Jul 29, 2021
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 29, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2021
@ghost

Deleted user (ghost) commented Aug 5, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 5, 2021
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 5, 2021

Copy link
Copy Markdown
Member

This is a tool not part of PowerShell, so not a breaking change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@TravisEz13 Travis Plunk (TravisEz13) changed the title Fix CA1052 in TypeCatalogGen Fix CA1052 in TypeCatalogGen Aug 5, 2021
@TravisEz13
Travis Plunk (TravisEz13) merged commit 44595a4 into PowerShell:master Aug 5, 2021
@TravisEz13 Travis Plunk (TravisEz13) added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@xtqqczze
xtqqczze deleted the CA1052-p3 branch August 6, 2021 02:27
@ghost

Deleted user (ghost) commented Aug 23, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

Deleted user (ghost) commented Sep 28, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix CA1052 in TypeCatalogGen (PowerShell#15840)
3b475ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.9

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@xtqqczze @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.