GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add completion for loop labels after Break/Continue by MartinGC94 · Pull Request #16438 · PowerShell/PowerShell

Conversation

@MartinGC94

@MartinGC94 MartinGC94 commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

PR Summary

Adds completion for loop labels after labeled control flow statements such as Break and Continue.
The completion will look for any loops with a label that surrounds the Break/Continue keywords.
The tooltips for the completion entries shows the relevant loop.

PR Context

Tab completion is always convenient because it helps prevents typos. It also helps prevent a relatively common mistake of including a colon in the label after Break/Continue.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MartinGC94
Add completion for loop labels
c6c53de
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Nov 10, 2021
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Nov 10, 2021
iSazonov
Ilya (iSazonov) reviewed Nov 11, 2021
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94 @iSazonov
Update src/System.Management.Automation/engine/CommandCompletion/Comp…
5f31919
…letionAnalysis.cs

Co-authored-by: Ilya <[email protected]>
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 19, 2021
@ghost

Deleted user (ghost) commented Nov 19, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Dongbo Wang (daxian-dbw) January 3, 2022 19:38
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 3, 2022

Copy link
Copy Markdown
Member

Adding Dongbo Wang (@daxian-dbw) as area expert.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 3, 2022
iSazonov
Ilya (iSazonov) reviewed Jan 4, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94 @iSazonov
Apply suggestions from code review
1681154
Co-authored-by: Ilya <[email protected]>
@iSazonov

Ilya (iSazonov) commented Jan 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Can follow work (without closing brackets)?
:Outer do {:Inner while ($true){ break } continue ^

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
Handle completion for incomplete switches and Do loops.
8a6a51e
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Small and removed Extra Small labels Jan 5, 2022
@MartinGC94
Move tests from help context to misc context.
3fb05ca
@MartinGC94

MartinGC94 commented Jan 5, 2022

Copy link
Copy Markdown
Contributor Author

Can follow work (without closing brackets)? :Outer do {:Inner while ($true){ break } continue ^

Now it does :)
I doubt most people will notice though. If you are using loop labels you are almost certainly editing in an editor and using snippets to create the loops.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Jan 6, 2022
View reviewed changes
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 6, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 13, 2022
@ghost

Deleted user (ghost) commented Jan 13, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Jan 13, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 13, 2022
@daxian-dbw Dongbo Wang (daxian-dbw) added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 18, 2022
@MartinGC94
Add comment and tests
92554ba
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 18, 2022
@MartinGC94
Fix expected string in new tests
2673047
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Jan 18, 2022

Copy link
Copy Markdown

This PR has 68 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +68 -0
Percentile : 27.2%

Total files changed: 2

Change summary by file extension:
.cs : +22 -0
.ps1 : +46 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 18, 2022
View reviewed changes
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 26, 2022
@ghost

Deleted user (ghost) commented Jan 26, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Needed The PR is being reviewed label Jan 26, 2022
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jan 26, 2022

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) This PR is ready to be merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Aditya Patwardhan (adityapatwardhan) Feb 1, 2022
@iSazonov
Ilya (iSazonov) merged commit 7d3260f into PowerShell:master Feb 1, 2022
@iSazonov

Ilya (iSazonov) commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator

MartinGC94 Thanks for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
MartinGC94 deleted the LoopLabelCompletion branch February 1, 2022 07:50
@ghost

Deleted user (ghost) commented Feb 24, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@MartinGC94
Add completion for loop labels after Break/Continue (PowerShell#16438)
cea2e67
Adds completion for loop labels after labeled control flow statements such as Break and Continue.
The completion will look for any loops with a label that surrounds the Break/Continue keywords.
The tooltips for the completion entries shows the relevant loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MartinGC94 @adityapatwardhan @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.