GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve hashtable completion by MartinGC94 · Pull Request #16498 · PowerShell/PowerShell

Conversation

@MartinGC94

@MartinGC94 MartinGC94 commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes a few things about hashtable completion:

  1. Use partial input to filter the suggested keys
  2. Filters out keys that have already been specified in the hashtable
  3. Allows hashtable key completion to happen on blank lines, even if a key/value pair was specified on an earlier line

Example of a scenario that currently fails, but will get fixed by this PR:

ls | sort @{
Expression={}
<Cursor here>
}

Also adds completers for the Arguments parameter for Invoke-CimMethod the FilterHashtable parameter for Get-WinEvent the Property Parameter for the cim cmdlets and the standard cim completers for Set-CimInstance.
This also removes duplicates from member completion in scenarios like ls | select Attributes,<Cursor here> this could be split off into its own PR but since it depends on changes made in this PR I thought I may as well include it here.
Finally it adds some basic completion support for hashtables used for splatting. The pseudo binding doesn't take the hashtable parameters into account so it's not perfect but IMO some completion is better than none.

Fixes #9239

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

HumanEquivalentUnit reacted with heart emoji
All reactions
  • ❤️ 1 reaction
MartinGC94 added 2 commits November 21, 2021 04:35
@MartinGC94
Fix some hashtable completion issues. Prevent completion of keys alre…
6276e7f
…ady in a hashtable and add argument completers for Get-WinEvent and Invoke-CimMethod
@MartinGC94
Remove some leading space
4012271
@ghost ghost assigned Aditya Patwardhan (adityapatwardhan) Nov 21, 2021
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Medium label Nov 21, 2021
MartinGC94 added 2 commits November 21, 2021 11:48
@MartinGC94
Skip Get-WinEvent test on non-Windows platforms
8a54574
@MartinGC94
Add missing test and additional details to the Cim method parameter t…
e6ab314
…ooltip
@iSazonov

Ilya (iSazonov) commented Nov 24, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I like this
image
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) November 24, 2021 04:41
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 1, 2021
@ghost

Deleted user (ghost) commented Dec 1, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
Add completion for hashtables used for splatting and the Property par…
a4807c4
…ameter for Cim cmdlets.
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Large and removed Medium labels Dec 5, 2021
iSazonov
Ilya (iSazonov) reviewed Dec 6, 2021
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

MartinGC94 and others added 2 commits December 6, 2021 14:10
@MartinGC94 @iSazonov
Apply suggestions from code review
dd059fe
Co-authored-by: Ilya <[email protected]>
@MartinGC94
Add comments, move test and replace alias with the proper command nam…
cb71343
…e in test.
iSazonov
Ilya (iSazonov) approved these changes Dec 6, 2021
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 6, 2021
@MartinGC94
Add empty line before return statement.
f7911d0
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Jan 3, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 3, 2022

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) can you have a look?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 3, 2022
@MartinGC94 @adityapatwardhan
Apply suggestions from code review
4c332e2
Co-authored-by: Aditya Patwardhan <[email protected]>
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 11, 2022
@ghost

Deleted user (ghost) commented Jan 11, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94

MartinGC94 commented Feb 15, 2022

Copy link
Copy Markdown
Contributor Author

I understand if you are busy, to help prioritize I will say that out of all my open PRs, this is the one I'm most interested in seeing in the near future. It's just so convenient being able to tab complete parameters in splatting hashtables.

fMichaleczek and hrxn reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Feb 16, 2022

Copy link
Copy Markdown
Member

MartinGC94 Sorry for the long delay on this. I will get to this PR this week.

MartinGC94 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 16, 2022
@MartinGC94
Maybe fix merge conflict?
848a1d4
@MartinGC94
Merge branch 'master' into ImprovedHashtableCompletion
c65d3b5
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 23, 2022
@ghost

Deleted user (ghost) commented Feb 23, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Mar 1, 2022
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on review.
The changes overall look good. Thanks for the improvements!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionAnalysis.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

MartinGC94 and others added 3 commits March 1, 2022 22:56
@MartinGC94 @daxian-dbw
Apply suggestions from code review
4abd93c
Co-authored-by: Dongbo Wang <[email protected]>
@MartinGC94
Apply changes suggested by daxian-dbw
5c7be2d
@daxian-dbw
Break up the code a little to avoid CodeFactor issues
6ff02f5
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Mar 1, 2022
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Dongbo Wang (daxian-dbw) and unassigned Aditya Patwardhan (adityapatwardhan) Mar 1, 2022
@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 1, 2022
@daxian-dbw Dongbo Wang (daxian-dbw) closed this Mar 3, 2022
@daxian-dbw Dongbo Wang (daxian-dbw) reopened this Mar 3, 2022
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Mar 3, 2022

Copy link
Copy Markdown

This PR has 285 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +234 -51
Percentile : 68.5%

Total files changed: 4

Change summary by file extension:
.cs : +178 -48
.ps1 : +56 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Mar 4, 2022

Copy link
Copy Markdown
Member

The Invoke-RestMethod test failures are known issue, not related to changes in this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit c196e2f into PowerShell:master Mar 4, 2022
@ghost

Deleted user (ghost) commented Mar 21, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Mar 21, 2022
Request: Improve user experience of Get-WinEvent -FilterHashtable #9239
Closed
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Mar 23, 2022
Update release notes for 7.3-preview.3 MicrosoftDocs/PowerShell-Docs#8684
Closed
2 tasks done
@MartinGC94
MartinGC94 deleted the ImprovedHashtableCompletion branch June 5, 2022 08:29
@santisq

Santiago Squarzon (santisq) commented Nov 22, 2022

Copy link
Copy Markdown

Sorry if this is not the right place to comment but I've just noticed this a few days ago and I must say it's amazing. Thank you for the hard work! 💪

MartinGC94, SeeminglyScience, and daxian-dbw reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SeeminglyScience

Patrick Meinecke (SeeminglyScience) commented Nov 23, 2022 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

MartinGC94 don't know if you have a presence in twitter or reddit, but in case you don't lurk here's some more folks very excited to hear about this finally coming 😁

https://twitter.com/SeeminglyScienc/status/1595149054610399232

https://old.reddit.com/r/PowerShell/comments/z2qxed/powershell_ide_that_supports_tab/ixi3yu8/?context=10000

Twitter
reddit
PowerShell IDE That Supports Tab Completion/Intellisense for PowerShell Classes
It's worth noting that this PR is one of *many* of Martin's absolutely incredible PRs. A good chunk of which made it into v7.3.0 GA including...
santisq reacted with laugh emoji MartinGC94 reacted with heart emoji
All reactions
  • 😄 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94

MartinGC94 commented Nov 23, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the kind words :)
It's always nice to hear people appreciate one's work. ❤

daxian-dbw, santisq, iSazonov, and SeeminglyScience reacted with heart emoji
All reactions
  • ❤️ 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@unfurl-links unfurl-links Bot mentioned this pull request Mar 25, 2025
Add completers for the Property parameter for Compare-Object and ConvertTo-Html #25233
Open
8 of 21 tasks
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@MartinGC94
Improve Hashtable completion in multiple scenarios (PowerShell#16498)
de21e16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request: Improve user experience of Get-WinEvent -FilterHashtable

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@MartinGC94 @iSazonov @adityapatwardhan @daxian-dbw @santisq @SeeminglyScience
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.