GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow multiple installations of dotnet. by JamesWTruher · Pull Request #17141 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

A new flag for removal is now provided, but by default we will add a new version of dotnet.

PR Summary

This adds the proper flag to not damage a new installation of dotnet if one exists.
Additionally, we will no longer automatically delete previous versions of dotnet. Previous versions of dotnet may still be removed by using the new -RemovePreviousVersion parameter of Install-Dotnet

PR Context

Current install-dotnet will break dotnet use if another version already exists. This PR adds the -skipnonversionedfiles parameter when calling dotnet-install which avoids this behavior.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JamesWTruher
James Truher (JamesWTruher) requested review from Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners April 12, 2022 18:42
@ghost ghost assigned Paul Higinbotham (PaulHigin) Apr 12, 2022
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Extra Small label Apr 12, 2022
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Consider labels Apr 12, 2022
TravisEz13
Travis Plunk (TravisEz13) approved these changes Apr 12, 2022
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Apr 12, 2022

Copy link
Copy Markdown
Member

We should consider this for backport to avoid extra work in fixing local mac dev machines, but we should get at least one preview release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JamesWTruher
Allow multiple installations of dotnet.
095e203
A new flag for removal is now provided, but by default we will add a new version of dotnet.
@JamesWTruher
James Truher (JamesWTruher) force-pushed the FixDotnetInstall01 branch from c0b59b1 to 095e203 Compare April 12, 2022 19:10
@JamesWTruher
Add updated CG manifest.
b59e07f
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Apr 12, 2022

Copy link
Copy Markdown

This PR has 29 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +17 -12
Percentile : 11.6%

Total files changed: 2

Change summary by file extension:
.psm1 : +14 -9
.json : +3 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

PaulHigin
Paul Higinbotham (PaulHigin) suggested changes Apr 12, 2022
View reviewed changes
Comment thread build.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 12, 2022
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Apr 12, 2022
View reviewed changes
@PaulHigin
Paul Higinbotham (PaulHigin) merged commit 9c13c04 into PowerShell:master Apr 12, 2022
@JamesWTruher
James Truher (JamesWTruher) deleted the FixDotnetInstall01 branch April 12, 2022 21:35
James Truher (JamesWTruher) added a commit to JamesWTruher/PSScriptAnalyzer that referenced this pull request Apr 12, 2022
@JamesWTruher
Be sure not to clobber existing files when installing dotnet.
a6c880f
This is the same fix as PowerShell/PowerShell#17141
@JamesWTruher James Truher (JamesWTruher) mentioned this pull request Apr 12, 2022
Be sure not to clobber existing files when installing dotnet. PowerShell/PSScriptAnalyzer#1788
Merged
6 tasks done
@TravisEz13 Travis Plunk (TravisEz13) added BackPort-7.0.x-Approved and removed BackPort-7.0.x-Consider labels Apr 26, 2022
@TravisEz13

Travis Plunk (TravisEz13) commented Apr 28, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.2.4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Apr 28, 2022 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.2.4: https://github.com/PowerShell/PowerShell/actions/runs/2242321819

GitHub
Allow multiple installations of dotnet. · PowerShell/PowerShell@42ad8b9
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Apr 28, 2022
[release/v7.2.4] Allow multiple installations of dotnet. #17216
Merged
1 task
@TravisEz13 Travis Plunk (TravisEz13) added the Backport-7.2.x-Done label Apr 29, 2022
@TravisEz13 Travis Plunk (TravisEz13) removed the Backport-7.2.x-Approved label Apr 29, 2022
@JamesWTruher James Truher (JamesWTruher) removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2022
@TravisEz13

Travis Plunk (TravisEz13) commented May 9, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.0.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented May 9, 2022 •
edited by unfurl-links Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2295866950

GitHub
Allow multiple installations of dotnet. · PowerShell/PowerShell@a33b5d3
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented May 9, 2022

Copy link
Copy Markdown
Contributor

Travis Plunk (@TravisEz13) backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Allow multiple installations of dotnet.
Using index info to reconstruct a base tree...
M	build.psm1
Falling back to patching base and 3-way merge...
Auto-merging build.psm1
CONFLICT (content): Merge conflict in build.psm1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow multiple installations of dotnet.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@TravisEz13

Travis Plunk (TravisEz13) commented May 9, 2022

Copy link
Copy Markdown
Member

Have Jim do the backport once we open the 7.0.12 branch. This is not required.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented May 23, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

James Truher (JamesWTruher) added a commit to PowerShell/PSScriptAnalyzer that referenced this pull request May 23, 2022
@JamesWTruher
Be sure not to clobber existing files when installing dotnet. (#1788)
e6019da
This is the same fix as PowerShell/PowerShell#17141
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 10, 2022

Copy link
Copy Markdown
Member

/backport to release/v7.0.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) removed the BackPort-7.0.x-Approved label Aug 10, 2022
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 10, 2022

Copy link
Copy Markdown
Member

Not needed for release. This makes working on mac easier, no effect during the release process

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Rob Holt (rjmholt) pushed a commit to rjmholt/Specter that referenced this pull request Feb 22, 2026
@JamesWTruher @rjmholt
Be sure not to clobber existing files when installing dotnet. (#1788)
28aa4c3
This is the same fix as PowerShell/PowerShell#17141
Rob Holt (rjmholt) pushed a commit to rjmholt/Specter that referenced this pull request Feb 23, 2026
@JamesWTruher
Be sure not to clobber existing files when installing dotnet. (#1788)
9a337ee
This is the same fix as PowerShell/PowerShell#17141
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher
Allow multiple installations of dotnet. (PowerShell#17141)
39aa538
* Allow multiple installations of dotnet.

A new flag for removal is now provided, but by default we will add a new version of dotnet.

* Add updated CG manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
+1 more reviewer
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@PaulHigin Paul Higinbotham (PaulHigin)

Labels

Backport-7.2.x-Done Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JamesWTruher @TravisEz13 @adityapatwardhan @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.