GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve hashtable key completion for type constrained variable assignments, nested hashtables and more by MartinGC94 · Pull Request #17660 · PowerShell/PowerShell

Conversation

@MartinGC94

@MartinGC94 MartinGC94 commented Jul 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Fixes PowerShell/PowerShellEditorServices#1852
Decided to make a full fix for all hashtable key completion scenarios I could think of:

  • Fixes type inference for ConvertExpressions that use a PowerShell type that hasn't been loaded yet.
  • Fix tab completion for constructor hashtables so it only completes properties if the class has a null constructor or if it's an interface.
  • Fix tab completion for constructor hashtables that use a PowerShell type that hasn't been loaded yet.
  • Fix tab completion for nested hashtables like: Get-WinEvent -FilterHashtable @{SuppressHashFilter=@{<Tab>
  • Fix tab completion for hashtables that are in an array of arguments like: ls | select Name,@{<Tab>}
  • Add the same property completion that exists for type conversions to typed variables command parameters and Property assignments
  • Add completion for the module specification used in using module @{<Tab>

PR Context

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None
    • OR
    • Experimental feature(s) needed
      • Experimental feature name(s):
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed
      • Issue filed:
  • Testing - New and feature
    • N/A or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
    • OR
    • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
      • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
        (which runs in a different PS Host).
        • Issue filed:
      • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
        • Issue filed:
      • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
        • Issue filed:
      • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
        • Issue filed:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SeeminglyScience, andyleejordan, and santisq reacted with heart emoji
All reactions
  • ❤️ 3 reactions
@MartinGC94
Add completion for hashtable property definitions for typed variables…
15aae32
… and command parameters
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added the Small label Jul 10, 2022
@ghost ghost assigned Andrew (anmenaga) Jul 10, 2022
@iSazonov
Ilya (iSazonov) requested review from Patrick Meinecke (SeeminglyScience) and Dongbo Wang (daxian-dbw) July 12, 2022 06:33
@ghost ghost added the Review - Needed The PR is being reviewed label Jul 19, 2022
@ghost

Deleted user (ghost) commented Jul 19, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 20, 2022
dkaszews
Dominik Kowalski (dkaszews) reviewed Aug 2, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Aug 3, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
Fixes type inference for ConvertExpressions that use a PowerShell typ…
f7fdcb1
…e that hasn't been loaded yet.

Fix tab completion for constructor hashtables so it only completes properties if the class has a null constructor.
Fix tab completion for constructor hashtables that use a PowerShell type that hasn't been loaded yet.
Fix tab completion for nested hashtables like Get-WinEvent -FilterHashtable @{SuppressHashFilter=@{<Tab>
Fix tab completion for hashtables that are in an array of arguments like: ls | select Name,@{<Tab>}
Add the same property completion that exists for type conversions to typed variables command parameters and Property assignments
@pull-request-quantifier-deprecated pull-request-quantifier-deprecated Bot added Large and removed Small labels Aug 8, 2022
@MartinGC94 MartinGC94 changed the title Add completion for hashtable property definitions for typed variables WIP: Add completion for hashtable property definitions for typed variables Aug 8, 2022
MartinGC94 and others added 2 commits August 9, 2022 21:46
@MartinGC94
Merge branch 'master' into AddCompletionForTypedVariables
7bf6736
@MartinGC94
Add missing tests
1455f2e
Fix class name as requested by iSazonov
Add enumeration for the inferred types
@MartinGC94 MartinGC94 changed the title WIP: Add completion for hashtable property definitions for typed variables Improve hashtable key completion for type constrained variable assignments, nested hashtables and more Aug 11, 2022
@MartinGC94
Exclude interfaces from the null constructor check
5a46afd
@MartinGC94 MartinGC94 closed this Aug 15, 2022
@MartinGC94 MartinGC94 reopened this Aug 15, 2022
MartinGC94 and others added 3 commits August 18, 2022 18:03
@MartinGC94
Add completion for module specification keys in using module statement
c715ee5
@MartinGC94
Merge branch 'master' into AddCompletionForTypedVariables
eb05d9e
@MartinGC94
Merge branch 'PowerShell:master' into AddCompletionForTypedVariables
31474e2
@pull-request-quantifier-deprecated

pull-request-quantifier-deprecated Bot commented Dec 14, 2022

Copy link
Copy Markdown

This PR has 362 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +256 -106
Percentile : 76.2%

Total files changed: 3

Change summary by file extension:
.cs : +191 -77
.ps1 : +65 -29

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

Patrick Meinecke (@SeeminglyScience) Please review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 14, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 22, 2022
@ghost

Deleted user (ghost) commented Dec 22, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Apr 25, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review. Not finished yet, but want to share feedback so far.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
Merge branch 'PowerShell:master' into AddCompletionForTypedVariables
81f5468
@MartinGC94
Apply Dongbo suggestion.
7e435e5
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Apr 25, 2023
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@MartinGC94
Return early when encountering unexpected Ast
12cf01f
@daxian-dbw Dongbo Wang (daxian-dbw) added the CommunityDay-Large A large PR that the PS team has identified to prioritize to review label May 1, 2023
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes May 1, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine the use of goto LABEL here to break out of the loop. It's not that confusing to get what it does by reading the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 5605b24 into PowerShell:master May 1, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@daxian-dbw

Dongbo Wang (daxian-dbw) commented May 1, 2023

Copy link
Copy Markdown
Member

MartinGC94 Thanks for the contribution and I appreciate your patience.

MartinGC94 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andyleejordan

Andy Jordan (andyleejordan) commented May 2, 2023

Copy link
Copy Markdown
Member

This is awesome work!

MartinGC94 and SeeminglyScience reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost

Deleted user (ghost) commented Jun 29, 2023

Copy link
Copy Markdown

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

  • Release Notes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ghost ghost mentioned this pull request Jun 29, 2023
Install-Module failed: Issue with converting to SemanticVersion in Install-Package #1852
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@MartinGC94
Improve Hashtable key completion for type constrained variable assign…
abcc3d2
…ments, nested Hashtables and more (PowerShell#17660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SeeminglyScience Patrick Meinecke (SeeminglyScience) Awaiting requested review from SeeminglyScience SeeminglyScience is a code owner
+1 more reviewer
@dkaszews Dominik Kowalski (dkaszews) dkaszews left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CommunityDay-Large A large PR that the PS team has identified to prioritize to review Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typed Variables should intellisense hashtable properties

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@MartinGC94 @iSazonov @daxian-dbw @andyleejordan @dkaszews @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.